Skip to content

Commit 38704f9

Browse files
authored
refactor: use utils isArray (#756)
Co-authored-by: webfansplz <>
1 parent 0fe0088 commit 38704f9

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

src/mixin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ export function mixin(Vue: VueConstructor) {
176176
return visited.get(target)
177177
}
178178
visited.set(target, false)
179-
if (Array.isArray(target) && isReactive(target)) {
179+
if (isArray(target) && isReactive(target)) {
180180
visited.set(target, true)
181181
return true
182182
}

src/reactivity/del.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
import { AnyObject } from '../types/basic'
22
import { getVueConstructor } from '../runtimeContext'
3-
import { hasOwn, isPrimitive, isUndef, isValidArrayIndex } from '../utils'
3+
import {
4+
hasOwn,
5+
isPrimitive,
6+
isUndef,
7+
isArray,
8+
isValidArrayIndex,
9+
} from '../utils'
410

511
/**
612
* Delete a property and trigger change if necessary.
@@ -14,7 +20,7 @@ export function del(target: AnyObject, key: any) {
1420
`Cannot delete reactive property on undefined, null, or primitive value: ${target}`
1521
)
1622
}
17-
if (Array.isArray(target) && isValidArrayIndex(key)) {
23+
if (isArray(target) && isValidArrayIndex(key)) {
1824
target.splice(key, 1)
1925
return
2026
}

src/reactivity/reactive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ function setupAccessControl(target: AnyObject): void {
4141
if (
4242
!isPlainObject(target) ||
4343
isRaw(target) ||
44-
Array.isArray(target) ||
44+
isArray(target) ||
4545
isRef(target) ||
4646
isComponentInstance(target) ||
4747
accessModifiedSet.has(target)

0 commit comments

Comments
 (0)