Skip to content

Commit 55a61c9

Browse files
committed
fix: hyphenate _defineElementProperty remove shouldReflect false
1 parent 434f0fa commit 55a61c9

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

packages/runtime-dom/__tests__/customElement.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ describe('defineCustomElement', () => {
232232
expect(el.maxAge).toBe(100)
233233
})
234234

235+
// # 5793
235236
test('set number value in dom property', () => {
236237
const E = defineCustomElement({
237238
props: {

packages/runtime-dom/src/apiCustomElement.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ export class VueElement extends BaseClass {
245245
for (const key of rawKeys.map(camelize)) {
246246
this._defineElementProperty(key)
247247
if (hyphenate(key) !== key) {
248-
this._defineElementProperty(hyphenate(key), key, false)
248+
this._defineElementProperty(hyphenate(key), key)
249249
}
250250
}
251251

@@ -264,17 +264,13 @@ export class VueElement extends BaseClass {
264264
}
265265
}
266266

267-
private _defineElementProperty(
268-
key: string,
269-
originalKey = key,
270-
shouldReflect = true
271-
) {
267+
private _defineElementProperty(key: string, originalKey = key) {
272268
Object.defineProperty(this, key, {
273269
get() {
274270
return this._getProp(originalKey)
275271
},
276272
set(val) {
277-
this._setProp(originalKey, val, shouldReflect)
273+
this._setProp(originalKey, val)
278274
}
279275
})
280276
}

0 commit comments

Comments
 (0)