Skip to content

Commit 7a0a665

Browse files
committed
docs: update contributing guide
1 parent 40dab4d commit 7a0a665

File tree

2 files changed

+50
-25
lines changed

2 files changed

+50
-25
lines changed

.github/contributing.md

Lines changed: 49 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Hi! I'm really excited that you are interested in contributing to Vue.js. Before
3030

3131
- If you are resolving a special issue, add `(fix #xxxx[,#xxxx])` (#xxxx is the issue id) in your PR title for a better release log, e.g. `update entities encoding/decoding (fix #3899)`.
3232
- Provide a detailed description of the bug in the PR. Live demo preferred.
33-
- Add appropriate test coverage if applicable. You can check the coverage of your code addition by running `npm test -- --coverage`.
33+
- Add appropriate test coverage if applicable. You can check the coverage of your code addition by running `nr test-coverage`.
3434

3535
- It's OK to have multiple small commits as you work on the PR - GitHub can automatically squash them before merging.
3636

@@ -70,16 +70,28 @@ $ pnpm i # install the dependencies of the project
7070
A high level overview of tools used:
7171

7272
- [TypeScript](https://www.typescriptlang.org/) as the development language
73-
- [Rollup](https://rollupjs.org) for bundling
74-
- [Jest](https://jestjs.io/) for unit testing
73+
- [Vite](https://vitejs.dev/) and [ESBuild](https://esbuild.github.io/) for development bundling
74+
- [Rollup](https://rollupjs.org) for production bundling
75+
- [Vitest](https://vitest.dev/) for unit testing
7576
- [Prettier](https://prettier.io/) for code formatting
77+
- [ESLint](https://eslint.org/) for static error prevention (outside of types)
7678

7779
## Scripts
7880

7981
**The examples below will be using the `nr` command from the [ni](https://github.com/antfu/ni) package.** You can also use plain `npm run`, but you will need to pass all additional arguments after the command after an extra `--`. For example, `nr build runtime --all` is equivalent to `npm run build -- runtime --all`.
8082

8183
The `run-s` and `run-p` commands found in some scripts are from [npm-run-all](https://github.com/mysticatea/npm-run-all) for orchestrating multiple scripts. `run-s` means "run in sequence" while `run-p` means "run in parallel".
8284

85+
- [`nr build`](#nr-build)
86+
- [`nr build-dts`](#nr-build-dts)
87+
- [`nr check`](#nr-check)
88+
- [`nr dev`](#nr-dev)
89+
- [`nr dev-sfc`](#nr-dev-sfc)
90+
- [`nr dev-esm`](#nr-dev-esm)
91+
- [`nr dev-compiler`](#nr-dev-compiler)
92+
- [`nr test`](#nr-test)
93+
- [`nr test-dts`](#nr-test-dts)
94+
8395
### `nr build`
8496

8597
The `build` script builds all public packages (packages without `private: true` in their `package.json`).
@@ -94,6 +106,8 @@ nr build runtime-core
94106
nr build runtime --all
95107
```
96108

109+
Note that `nr build` uses `rollup-plugin-esbuild` for transpiling typescript and **does not perform type checking**. To run type check on the entire codebase, run `nr check`.
110+
97111
#### Build Formats
98112

99113
By default, each package will be built in multiple distribution formats as specified in the `buildOptions.formats` field in its `package.json`. These can be overwritten via the `-f` flag. The following formats are supported:
@@ -127,13 +141,11 @@ nr build runtime-core -f esm-browser,cjs
127141

128142
Use the `--sourcemap` or `-s` flag to build with source maps. Note this will make the build much slower.
129143

130-
#### Build with Type Declarations
144+
### `nr build-dts`
131145

132-
The `--types` or `-t` flag will generate type declarations during the build and in addition:
146+
This command builds the type declarations for all packages. It first generates the raw `.d.ts` files in the `temp` directory, then uses [rollup-plugin-dts](https://github.com/Swatinem/rollup-plugin-dts) to roll the types into a single `.d.ts` file for each package.
133147

134-
- Roll the declarations into a single `.d.ts` file for each package;
135-
- Generate an API report in `<projectRoot>/temp/<packageName>.api.md`. This report contains potential warnings emitted by [api-extractor](https://api-extractor.com/).
136-
- Generate an API model json in `<projectRoot>/temp/<packageName>.api.json`. This file can be used to generate a Markdown version of the exported APIs.
148+
### `nr check`
137149

138150
### `nr dev`
139151

@@ -142,7 +154,7 @@ The `dev` script bundles a target package (default: `vue`) in a specified format
142154
```bash
143155
$ nr dev
144156

145-
> watching: packages/vue/dist/vue.global.js
157+
> built: packages/vue/dist/vue.global.js
146158
```
147159

148160
- **Important:** output of the `dev` script is for development and debugging only. While it has the same runtime behavior, the generated code should never be published to npm.
@@ -169,23 +181,30 @@ The `dev-compiler` script builds, watches and serves the [Template Explorer](htt
169181

170182
### `nr test`
171183

172-
The `test` script simply calls the `jest` binary, so all [Jest CLI Options](https://jestjs.io/docs/en/cli) can be used. Some examples:
184+
The `test` script simply calls the `vitest` binary, so all [Vitest CLI Options](https://vitest.dev/guide/cli.html#options) can be used. Some examples:
173185

174186
```bash
175-
# run all tests
187+
# run all tests in watch mode
176188
$ nr test
177189

190+
# run once and exit (equivalent to `vitest run`)
191+
$ nr test run
192+
178193
# run all tests under the runtime-core package
179194
$ nr test runtime-core
180195

181-
# run tests in a specific file
182-
$ nr test fileName
196+
# run tests in files matching the pattern
197+
$ nr test <fileNamePattern>
183198

184-
# run a specific test in a specific file
185-
$ nr test fileName -t 'test name'
199+
# run a specific test in specific files
200+
$ nr test <fileNamePattern> -t 'test name'
186201
```
187202

188-
The default `test` script includes the `--runInBand` jest flag to improve test stability, especially for the CSS transition related tests. When you are testing specific test specs, you can also run `npx jest` with flags directly to speed up tests (jest runs them in parallel by default).
203+
Tests that test against source code are grouped under `nr test-unit`, while tests that test against built files that run in real browsers are grouped under `nr test-e2e`.
204+
205+
### `nr test-dts`
206+
207+
Runs `nr build-dts` first, then verify the type tests in `packages/dts-test` are working correctly against the actual built type declarations.
189208

190209
## Project Structure
191210

@@ -209,14 +228,20 @@ This repository employs a [monorepo](https://en.wikipedia.org/wiki/Monorepo) set
209228

210229
- `compiler-ssr`: Compiler that produces render functions optimized for server-side rendering.
211230

212-
- `template-explorer`: A development tool for debugging compiler output. You can run `nr dev template-explorer` and open its `index.html` to get a repl of template compilation based on current source code.
213-
214-
A [live version](https://vue-next-template-explorer.netlify.com) of the template explorer is also available, which can be used for providing reproductions for compiler bugs. You can also pick the deployment for a specific commit from the [deploy logs](https://app.netlify.com/sites/vue-next-template-explorer/deploys).
215-
216231
- `shared`: Internal utilities shared across multiple packages (especially environment-agnostic utils used by both runtime and compiler packages).
217232

218233
- `vue`: The public facing "full build" which includes both the runtime AND the compiler.
219234

235+
- Private utility packages:
236+
237+
- `dts-test`: Contains type-only tests against generated dts files.
238+
239+
- `sfc-playground`: The playground continuously deployed at https://sfc.vuejs.org. To run the playground locally, use [`nr dev-sfc`](#nr-dev-sfc).
240+
241+
- `template-explorer`: A development tool for debugging compiler output, continuously deployed at https://template-explorer.vuejs.org/. To run it locally, run [`nr dev-compiler`](#nr-dev-compiler).
242+
243+
- `size-check`: Used for checking built bundle sizes on CI.
244+
220245
### Importing Packages
221246

222247
The packages can import each other directly using their package names. Note that when importing a package, the name listed in its `package.json` should be used. Most of the time the `@vue/` prefix is needed:
@@ -228,7 +253,7 @@ import { h } from '@vue/runtime-core'
228253
This is made possible via several configurations:
229254

230255
- For TypeScript, `compilerOptions.paths` in `tsconfig.json`
231-
- For Jest, `moduleNameMapper` in `jest.config.js`
256+
- Vitest and Rollup share the sae set of aliases from `scripts/aliases.mjs`
232257
- For plain Node.js, they are linked using [PNPM Workspaces](https://pnpm.io/workspaces).
233258

234259
### Package Dependencies
@@ -268,19 +293,19 @@ There are some rules to follow when importing across package boundaries:
268293

269294
## Contributing Tests
270295

271-
Unit tests are collocated with the code being tested in each package, inside directories named `__tests__`. Consult the [Jest docs](https://jestjs.io/docs/en/using-matchers) and existing test cases for how to write new test specs. Here are some additional guidelines:
296+
Unit tests are collocated with the code being tested in each package, inside directories named `__tests__`. Consult the [Vitest docs](https://vitest.dev/api/) and existing test cases for how to write new test specs. Here are some additional guidelines:
272297

273298
- Use the minimal API needed for a test case. For example, if a test can be written without involving the reactivity system or a component, it should be written so. This limits the test's exposure to changes in unrelated parts and makes it more stable.
274299

275300
- If testing platform agnostic behavior or asserting low-level virtual DOM operations, use `@vue/runtime-test`.
276301

277302
- Only use platform-specific runtimes if the test is asserting platform-specific behavior.
278303

279-
Test coverage is continuously deployed at https://vue-next-coverage.netlify.app/. PRs that improve test coverage are welcome, but in general the test coverage should be used as a guidance for finding API use cases that are not covered by tests. We don't recommend adding tests that only improve coverage but not actually test a meaning use case.
304+
Test coverage is continuously deployed at https://coverage.vuejs.org. PRs that improve test coverage are welcome, but in general the test coverage should be used as a guidance for finding API use cases that are not covered by tests. We don't recommend adding tests that only improve coverage but not actually test a meaning use case.
280305

281306
### Testing Type Definition Correctness
282307

283-
Type tests are located in the `test-dts` directory. To run the dts tests, run `nr test-dts`. Note that the type test requires all relevant `*.d.ts` files to be built first (and the script does it for you). Once the `d.ts` files are built and up-to-date, the tests can be re-run by simply running `nr test-dts`.
308+
Type tests are located in the `packages/dts-test` directory. To run the dts tests, run `nr test-dts`. Note that the type test requires all relevant `*.d.ts` files to be built first (and the script does it for you). Once the `d.ts` files are built and up-to-date, the tests can be re-run by running `nr test-dts-only`.
284309

285310
## Financial Contribution
286311

packages/dts-test/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ Tests Typescript types to ensure the types remain as expected.
44

55
- This directory is included in the root `tsconfig.json`, where package imports are aliased to `src` directories, so in IDEs and the `pnpm check` script the types are validated against source code.
66

7-
- When runnong `tsc` with `packages/dts-test/tsconfig.test.json`, packages are resolved using using normal `node` resolution, so the types are validated against actual **built** types. This requires the types to be built first via `pnpm build-types`.
7+
- When running `tsc` with `packages/dts-test/tsconfig.test.json`, packages are resolved using using normal `node` resolution, so the types are validated against actual **built** types. This requires the types to be built first via `pnpm build-types`.

0 commit comments

Comments
 (0)