Skip to content

Commit 85c1cc3

Browse files
ci: define Node version using environment variables
1 parent bd08f05 commit 85c1cc3

File tree

2 files changed

+18
-12
lines changed

2 files changed

+18
-12
lines changed

.github/workflows/canary.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ on:
55
- cron: 0 1 * * MON
66
workflow_dispatch:
77

8+
env:
9+
NODE_VERSION: 18
10+
811
jobs:
912
canary:
1013
# prevents this action from running on forks
@@ -17,10 +20,10 @@ jobs:
1720
- name: Install pnpm
1821
uses: pnpm/action-setup@v2
1922

20-
- name: Set node version to 18
23+
- name: Set node version to ${{ env.NODE_VERSION }}
2124
uses: actions/setup-node@v3
2225
with:
23-
node-version: 18
26+
node-version: ${{ env.NODE_VERSION }}
2427
registry-url: 'https://registry.npmjs.org'
2528
cache: 'pnpm'
2629

.github/workflows/ci.yml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ on:
1010
permissions:
1111
contents: read # to fetch code (actions/checkout)
1212

13+
env:
14+
NODE_VERSION: 18
15+
1316
jobs:
1417
unit-test:
1518
runs-on: ubuntu-latest
@@ -20,10 +23,10 @@ jobs:
2023
- name: Install pnpm
2124
uses: pnpm/action-setup@v2
2225

23-
- name: Set node version to 18
26+
- name: Set node version to ${{ env.NODE_VERSION }}
2427
uses: actions/setup-node@v3
2528
with:
26-
node-version: 18
29+
node-version: ${{ env.NODE_VERSION }}
2730
cache: 'pnpm'
2831

2932
- name: Skip Puppeteer download
@@ -43,10 +46,10 @@ jobs:
4346
- name: Install pnpm
4447
uses: pnpm/action-setup@v2
4548

46-
- name: Set node version to 18
49+
- name: Set node version to ${{ env.NODE_VERSION }}
4750
uses: actions/setup-node@v3
4851
with:
49-
node-version: 18
52+
node-version: ${{ env.NODE_VERSION }}
5053
cache: 'pnpm'
5154

5255
- name: Skip Puppeteer download
@@ -75,10 +78,10 @@ jobs:
7578
- name: Install pnpm
7679
uses: pnpm/action-setup@v2
7780

78-
- name: Set node version to 18
81+
- name: Set node version to ${{ env.NODE_VERSION }}
7982
uses: actions/setup-node@v3
8083
with:
81-
node-version: 18
84+
node-version: ${{ env.NODE_VERSION }}
8285
cache: 'pnpm'
8386

8487
- run: pnpm install
@@ -95,10 +98,10 @@ jobs:
9598
- name: Install pnpm
9699
uses: pnpm/action-setup@v2
97100

98-
- name: Set node version to 18
101+
- name: Set node version to ${{ env.NODE_VERSION }}
99102
uses: actions/setup-node@v3
100103
with:
101-
node-version: 18
104+
node-version: ${{ env.NODE_VERSION }}
102105
cache: 'pnpm'
103106

104107
- name: Skip Puppeteer download
@@ -126,10 +129,10 @@ jobs:
126129
- name: Install pnpm
127130
uses: pnpm/action-setup@v2
128131

129-
- name: Set node version to 18
132+
- name: Set node version to ${{ env.NODE_VERSION }}
130133
uses: actions/setup-node@v3
131134
with:
132-
node-version: 18
135+
node-version: ${{ env.NODE_VERSION }}
133136
cache: 'pnpm'
134137

135138
- run: PUPPETEER_SKIP_DOWNLOAD=1 pnpm install

0 commit comments

Comments
 (0)