test: add test

Author: edison1105

packages/reactivity/__tests__/watch.spec.ts

@@ -5,10 +5,12 @@ import {
   type WatchOptions,
   type WatchScheduler,
   computed,
+  effectScope,
   onWatcherCleanup,
   ref,
   watch,
 } from '../src'
+import { expect } from 'vitest'
 
 const queue: (() => void)[] = []
 
@@ -277,4 +279,44 @@ describe('watch', () => {
 
     expect(dummy).toEqual([1, 2, 3])
   })
+
+  test('removing a watcher while stopping its effectScope', async () => {
+    const count = ref(0)
+    const scope = effectScope()
+    let watcherCalls = 0
+    let cleanupCalls = 0
+
+    scope.run(() => {
+      const stop1 = watch(count, () => {
+        watcherCalls++
+      })
+      watch(count, (val, old, onCleanup) => {
+        watcherCalls++
+        onCleanup(() => {
+          cleanupCalls++
+          stop1()
+        })
+      })
+      watch(count, () => {
+        watcherCalls++
+      })
+    })
+
+    expect(watcherCalls).toBe(0)
+    expect(cleanupCalls).toBe(0)
+
+    count.value++
+    await nextTick()
+    expect(watcherCalls).toBe(3)
+    expect(cleanupCalls).toBe(0)
+
+    scope.stop()
+    count.value++
+    await nextTick()
+    expect(watcherCalls).toBe(3)
+    expect(cleanupCalls).toBe(1)
+
+    expect(scope.effects.length).toBe(0)
+    expect(scope.cleanups.length).toBe(0)
+  })
 })

packages/reactivity/src/effectScope.ts

@@ -118,8 +118,9 @@ export class EffectScope {
   stop(fromParent?: boolean): void {
     if (this._active) {
       let i, l
-      for (i = 0, l = this.effects.length; i < l; i++) {
-        this.effects[i].stop()
+      const effects = this.effects.slice()
+      for (i = 0, l = effects.length; i < l; i++) {
+        effects[i].stop()
       }
       const cleanups = this.cleanups.slice()
       for (i = 0, l = cleanups.length; i < l; i++) {