refactor(effect): use includes instead of indexOf (#286)

yeyan1996 · yyx990803 · commit 9a37c4b2c307 · 2019-10-15T11:18:26.000-04:00
diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts
@@ -88,7 +88,7 @@ function run(effect: ReactiveEffect, fn: Function, args: any[]): any {
   if (!effect.active) {
     return fn(...args)
   }
-  if (activeReactiveEffectStack.indexOf(effect) === -1) {
+  if (!activeReactiveEffectStack.includes(effect)) {
     cleanup(effect)
     try {
       activeReactiveEffectStack.push(effect)

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ function run(effect: ReactiveEffect, fn: Function, args: any[]): any {`
`88`	`88`	`if (!effect.active) {`
`89`	`89`	`return fn(...args)`
`90`	`90`	`}`
`91`		`- if (activeReactiveEffectStack.indexOf(effect) === -1) {`
	`91`	`+ if (!activeReactiveEffectStack.includes(effect)) {`
`92`	`92`	`cleanup(effect)`
`93`	`93`	`try {`
`94`	`94`	`activeReactiveEffectStack.push(effect)`