refactor: remove computedToAskDirty arg from trigger()

Author: johnsoncodehk

packages/reactivity/src/baseHandlers.ts

@@ -179,9 +179,9 @@ function createSetter(shallow = false) {
     // don't trigger if target is something up in the prototype chain of original
     if (target === toRaw(receiver)) {
       if (!hadKey) {
-        trigger(target, TriggerOpTypes.ADD, undefined, key, value)
+        trigger(target, TriggerOpTypes.ADD, key, value)
       } else if (hasChanged(value, oldValue)) {
-        trigger(target, TriggerOpTypes.SET, undefined, key, value, oldValue)
+        trigger(target, TriggerOpTypes.SET, key, value, oldValue)
       }
     }
     return result

packages/reactivity/src/collectionHandlers.ts

@@ -73,7 +73,7 @@ function add(this: SetTypes, value: unknown) {
   const hadKey = proto.has.call(target, value)
   if (!hadKey) {
     target.add(value)
-    trigger(target, TriggerOpTypes.ADD, undefined, value, value)
+    trigger(target, TriggerOpTypes.ADD, value, value)
   }
   return this
 }
@@ -94,9 +94,9 @@ function set(this: MapTypes, key: unknown, value: unknown) {
   const oldValue = get.call(target, key)
   target.set(key, value)
   if (!hadKey) {
-    trigger(target, TriggerOpTypes.ADD, undefined, key, value)
+    trigger(target, TriggerOpTypes.ADD, key, value)
   } else if (hasChanged(value, oldValue)) {
-    trigger(target, TriggerOpTypes.SET, undefined, key, value, oldValue)
+    trigger(target, TriggerOpTypes.SET, key, value, oldValue)
   }
   return this
 }
@@ -116,7 +116,7 @@ function deleteEntry(this: CollectionTypes, key: unknown) {
   // forward the operation before queueing reactions
   const result = target.delete(key)
   if (hadKey) {
-    trigger(target, TriggerOpTypes.DELETE, undefined, key, undefined, oldValue)
+    trigger(target, TriggerOpTypes.DELETE, key, undefined, oldValue)
   }
   return result
 }

packages/reactivity/src/effect.ts

@@ -259,7 +259,6 @@ export function trackEffects(
 export function trigger(
   target: object,
   type: TriggerOpTypes,
-  computedToAskDirty: ComputedRefImpl<any> | undefined,
   key?: unknown,
   newValue?: unknown,
   oldValue?: unknown,
@@ -324,9 +323,9 @@ export function trigger(
   if (deps.length === 1) {
     if (deps[0]) {
       if (__DEV__) {
-        triggerEffects(deps[0], computedToAskDirty, eventInfo)
+        triggerEffects(deps[0], undefined, eventInfo)
       } else {
-        triggerEffects(deps[0], computedToAskDirty)
+        triggerEffects(deps[0], undefined)
       }
     }
   } else {
@@ -337,9 +336,9 @@ export function trigger(
       }
     }
     if (__DEV__) {
-      triggerEffects(createDep(effects), computedToAskDirty, eventInfo)
+      triggerEffects(createDep(effects), undefined, eventInfo)
     } else {
-      triggerEffects(createDep(effects), computedToAskDirty)
+      triggerEffects(createDep(effects), undefined)
     }
   }
 }

packages/runtime-core/src/compat/global.ts

@@ -647,7 +647,7 @@ function defineReactiveSimple(obj: any, key: string, val: any) {
     },
     set(newVal) {
       val = isObject(newVal) ? reactive(newVal) : newVal
-      trigger(obj, TriggerOpTypes.SET, undefined, key, newVal)
+      trigger(obj, TriggerOpTypes.SET, key, newVal)
     }
   })
 }

packages/runtime-core/src/componentProps.ts

@@ -322,7 +322,7 @@ export function updateProps(
 
   // trigger updates for $attrs in case it's used in component slots
   if (hasAttrsChanged) {
-    trigger(instance, TriggerOpTypes.SET, undefined, '$attrs')
+    trigger(instance, TriggerOpTypes.SET, '$attrs')
   }
 
   if (__DEV__) {