Skip to content

types: support app.component to be defineComponent #9662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

pikax
Copy link
Member

@pikax pikax commented Nov 22, 2023

fix CI issue https://github.com/vuejs/ecosystem-ci/actions/runs/6925726707/job/18836836250

Probably because the type is just to complex to resolve as Component

I've seen this issue, other way to fix is to offload the component to a variable

// Too complex
awesomeFunction(defineComponent(/* ... */))

// works
const c = defineComponent(/* ... */)
awesomeFunction(c)

@pikax
Copy link
Member Author

pikax commented Nov 22, 2023

/ecosystem-ci run

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.5 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.4 kB 19.7 kB 17.9 kB
overall 61.4 kB 23.7 kB 21.6 kB

@vue-bot
Copy link
Contributor

vue-bot commented Nov 22, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
quasar success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success failure
vueuse success success
vue-simple-compiler success success

@yyx990803 yyx990803 merged commit 1c525f7 into main Nov 22, 2023
@yyx990803 yyx990803 deleted the pikax/types_fix_main_vuetify_integration branch November 22, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants