Skip to content

Commit 03d17cc

Browse files
committed
remove unnecessary booleans
1 parent 300d985 commit 03d17cc

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

src/guide/best-practices/performance.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,7 @@ Starting in 3.4, a computed property will only trigger effects when its computed
130130

131131
```js
132132
const count = ref(0)
133-
const isEven = computed(() => {
134-
return count.value % 2 === 0 ? true : false
135-
})
133+
const isEven = computed(() => count.value % 2 === 0)
136134

137135
watchEffect(() => console.log(isEven.value)) // true
138136

@@ -146,7 +144,7 @@ This reduces unnecessary effect triggers, but unfortunately doesn't work if the
146144
```js
147145
const computedObj = computed(() => {
148146
return {
149-
isEven: count.value % 2 === 0 ? true : false
147+
isEven: count.value % 2 === 0
150148
}
151149
})
152150
```
@@ -156,9 +154,9 @@ Because a new object is created each time, the new value is technically always d
156154
Instead, we can optimize this by manually comparing the new value with the old value, and conditionally returning the old value if we know nothing has changed:
157155

158156
```js
159-
const computedObj = computed(oldValue => {
157+
const computedObj = computed((oldValue) => {
160158
const newValue = {
161-
isEven: count.value % 2 === 0 ? true : false
159+
isEven: count.value % 2 === 0
162160
}
163161
if (oldValue && oldValue.isEven === newValue.isEven) {
164162
return oldValue
@@ -167,7 +165,7 @@ const computedObj = computed(oldValue => {
167165
})
168166
```
169167

170-
[Playground Example](https://play.vuejs.org/#eNqlVMlu2zAQ/ZUBgSZ24UpuczMkd4MPLdAFadEeyh4UibKVSKRADm2jhv+9Q1KyDTRRXOQggJrlzeO8Ge7Y27aN1lawGUtMrqsWwQi07ZzLqmmVRtiBFuUEctW0FkUxgU2G+WpRliJH2EOpVQOXhHDJJZe5kgYp1kqE1CWOpuOjXfikayvNzwpXyuKXFqum+pNhpWQX/+s3JfQwoeT9wb13pOriR1ZbAekcdlwCwaDVMpwBKrNYCzkLpKK1j3wGryBNU5jCa0BNhhmUWW2Ey9hzuX+Q8/mEz2YbUqXYdOYn8KakEo4VLi6gP0cBzSf3pTrbuC/Yta1POWB29j6tb8/JGIxG48N1BjUO14haa1ajAXW7sI7ffxU8p9rjpUorcy+cbYsMBVXzpeLYLUc33qggA53JguZfuN5K29wIfSIpafkpw1VU1krpkT+GeMJ7Di+nbjVc8FFfEgde0Ec6ExUukzjsJG0j/aBo2pro0B/Abtfx2HuRkhuLSITf5HWV36WcBeaczcNhmHQSh3SPnLjldwPhegqbIA+o03mm4sO73JGKA9S/iI/APYiVxCdNYBOGhnpdVsvo1ihJb5iXiTOndlUL7XBIC85m/ZBzltW12nz0NrdCk96er0R+d4/91mydjbOvWhih19TTgw8zvRQY3Itvn8WWzgdnowpbU/SA81oYVVvHMYS9s7Ig2idxnu0H/xJXcvndLLYopOkv5Yj6PfXxnNEz/H7g6ke6V9FV/9ax/V8w4Rl9)
168+
[Playground Example](https://play.vuejs.org/#eNqVVMtu2zAQ/JUFgSZK4UpuczMkow/40AJ9IC3aQ9mDIlG2EokUyKVt1PC/d0lKtoEminMQQC1nZ4c7S+7Yu66L11awGUtNoesOwQi03ZzLuu2URtiBFtUECtV2FkU5gU2OxWpRVaJA2EOlVQuXxHDJJZeFkgYJayVC5hKj6dUxLnzSjZXmV40rZfFrh3Vb/82xVrLH//5DCQNNKPkweNiNVFP+zBsrIJvDjksgGrRahjVAbRZrIWdBVLz2yBfwBrIsg6mD7LncPyryfIVnywupUmz68HOEEqqCI+XFBQzrOKR79MDdx66GCn1jhpQDZx8f0oZ+nBgdRVcH/aMuBt1xZ80qGvGvh/X6nlXwnGpPl6qsLLxTtitzFFTNl0oSN/79AKOCHHQuS5pw4XorbXsr9ImHZN7nHFdx1SilI78MeOJ7Ca+nbvgd+GgomQOv6CNjSQqXaRJuHd03+kHRdg3JoT+A3a7XsfcmpbcWkQS/LZq6uM84C8o5m4fFuOg0CemeOXXX2w2E6ylsgj2gTgeYio/f1l5UEqj+Z3yC7lGuNDlpApswNNTrql7Gd0ZJeqW8TZw5t+tGaMdDXnA2G4acs7xp1OaTj6G2YjLEi5Uo7h+I35mti3H2TQsj9Jp6etjDXC8Fhu3F9y9iS+vDZqtK2xB6ZPNGGNVYpzHA3ltZkuwTnFf70b+1tVz+MIstCmmGQzmh/p56PGf00H4YOfpR7nV8PTxubP8P2GAP9Q==)
171169

172170
Note that you should always perform the full computation before comparing and returning the old value, so that the same dependencies can be collected on every run.
173171

0 commit comments

Comments
 (0)