Skip to content

Commit 0753aa7

Browse files
rileymckennarileymckenna
committed
Made recommended changes.
1 parent df5ce46 commit 0753aa7

18 files changed

+104
-108
lines changed

‎src/Peering/Peering.Test/Peering.Test.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
<ItemGroup>
1414
<PackageReference Include="Microsoft.Azure.Management.Peering" Version="0.10.0-preview" />
15-
<PackageReference Include="Microsoft.Rest.ClientRuntime" Version="2.3.20" />
1615
</ItemGroup>
1716

1817
<ItemGroup>

‎src/Peering/Peering.Test/ScenarioTests/PeeringCommon.ps1

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,39 +75,39 @@ function maxAdvertisedIpv6
7575
function getHash
7676
{
7777
$hash = getPeeringVariable "Hash" $ipGenerator.BuildHash()
78-
Write-Debug("The hash $hash");
78+
Write-Debug "The hash $hash";
7979
return "$hash"
8080
}
8181

8282
function getBandwidth
8383
{
8484
$bandwidth = getPeeringVariable "bandwidth" $ipGenerator.GetBandwidth()
85-
Write-Debug("The bandwidth $bandwidth");
85+
Write-Debug "The bandwidth $bandwidth";
8686
return $bandwidth
8787
}
8888

8989
function getRandomNumber {
9090
$num = Get-Random -Maximum 65010 -Minimum 1
91-
Write-Debug("The random $num");
91+
Write-Debug "The random $num";
9292
return $num
9393
}
9494

9595
function makePeerAsn($asn)
9696
{
9797
$asnId = $asn
9898
$asnPeerName = getAssetName "$asn-Global"
99-
Write-Debug("PeerName $asnPeerName")
99+
Write-Debug "PeerName $asnPeerName"
100100
$asnPeer = getAssetName "AS$asn-Global"
101-
Write-Debug("PeerName $asnPeer")
101+
Write-Debug "PeerName $asnPeer"
102102
[string[]]$emails = "noc@$asnPeer.com","noc@$asnPeerName.com"
103103
$phone = getAssetName "2342432433"
104-
Write-Debug("Email: $emails; Phone $phone")
104+
Write-Debug "Email: $emails; Phone $phone"
105105
$created = New-AzPeerAsn -Name $asnPeerName -PeerName $asnPeer -PeerAsn $asnId -Email $emails -Phone $phone
106-
Write-Debug("PeerName " + $created.Name)
106+
Write-Debug "PeerName " + $created.Name
107107
$created.ValidationState = "Approved";
108-
Write-Debug("ValidationState: " + $created.ValidationState)
109-
Write-Debug("Sleep 2 seconds...")
110-
Sleep(2)
108+
Write-Debug "ValidationState: $created"
109+
Write-Debug "Sleep 2 seconds..."
110+
Wait-Seconds 2
111111
$created = $created | Set-AzPeerAsn
112112
return $created
113113
}

‎src/Peering/Peering.Test/ScenarioTests/ScenarioExchangePeeringTests.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ function Test-UpdateExchangeIPv4OnInputObject
9595
$peering.Tags = $tags;
9696
$peering.Connections[0] = $peering.Connections[0] | Set-AzPeeringExchangeConnectionObject -PeerSessionIPv4Address $newipv4
9797
$peering.Connections[1] = $peering.Connections[1] | Set-AzPeeringExchangeConnectionObject -PeerSessionIPv4Address $newipv42
98-
Write-Debug("ResourceId:"+$peering.Id)
98+
Write-Debug "ResourceId: $peering.Id"
9999
$update = $peering | Update-AzPeering
100100
Assert-AreEqual $newipv4 $update.Connections[0].BgpSession.PeerSessionIPv4Address
101101
Assert-AreEqual $newipv42 $update.Connections[1].BgpSession.PeerSessionIPv4Address
@@ -118,7 +118,7 @@ function Test-UpdateExchangeIPv6OnResourceId
118118
$oldpeering = $peering
119119
$peering.Connections[0] = $peering.Connections[0] | Set-AzPeeringExchangeConnectionObject -PeerSessionIPv6Address $newipv6
120120
$peering.Connections[1] = $peering.Connections[1] | Set-AzPeeringExchangeConnectionObject -PeerSessionIPv6Address $newipv62
121-
Write-Debug($peering.Name)
121+
Write-Debug $peering.Name
122122
$update = Update-AzPeering -ResourceId $peering.Id $peering.Connections
123123
Assert-NotNull $update
124124
Assert-AreEqual $newipv6 $update.Connections[0].BgpSession.PeerSessionIPv6Address

‎src/Peering/Peering/ChangeLog.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21-
22-
## Version 0.2.0
2321
* Bug fix in set connection
2422
* Added Connection Identifier to Connection object.
2523
* Updated to SDK 0.10.0-review

‎src/Peering/Peering/Peering.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
<ItemGroup>
1414
<PackageReference Include="AutoMapper" Version="6.2.2" />
15-
<PackageReference Include="Microsoft.Rest.ClientRuntime" Version="2.3.20" />
1615
<PackageReference Include="Microsoft.Azure.Management.Peering" Version="0.10.0-preview" />
1716
</ItemGroup>
1817

‎src/Peering/Peering/help/Get-AzLegacyPeering.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ Gets the legacy peering for Seattle
5858
The credentials, account, tenant, and subscription used for communication with Azure.
5959

6060
```yaml
61-
Type: IAzureContextContainer
61+
Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.Core.IAzureContextContainer
6262
Parameter Sets: (All)
6363
Aliases: AzContext, AzureRmContext, AzureCredential
6464

@@ -73,7 +73,7 @@ Accept wildcard characters: False
7373
Shows all Peering resource by Kind.
7474
7575
```yaml
76-
Type: String
76+
Type: System.String
7777
Parameter Sets: (All)
7878
Aliases:
7979

@@ -88,7 +88,7 @@ Accept wildcard characters: False
8888
Shows all Peering resource by Kind.
8989
9090
```yaml
91-
Type: String
91+
Type: System.String
9292
Parameter Sets: (All)
9393
Aliases:
9494

‎src/Peering/Peering/help/Get-AzPeerAsn.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Gets the PeerAsn
4242
The credentials, account, tenant, and subscription used for communication with Azure.
4343

4444
```yaml
45-
Type: IAzureContextContainer
45+
Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.Core.IAzureContextContainer
4646
Parameter Sets: (All)
4747
Aliases: AzContext, AzureRmContext, AzureCredential
4848

@@ -57,7 +57,7 @@ Accept wildcard characters: False
5757
The unique name of the PSPeering.
5858
5959
```yaml
60-
Type: String
60+
Type: System.String
6161
Parameter Sets: (All)
6262
Aliases:
6363

‎src/Peering/Peering/help/Get-AzPeering.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Gets the Exchange peering named `myExchangePeering1`
8585
The credentials, account, tenant, and subscription used for communication with Azure.
8686

8787
```yaml
88-
Type: IAzureContextContainer
88+
Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.Core.IAzureContextContainer
8989
Parameter Sets: (All)
9090
Aliases: AzContext, AzureRmContext, AzureCredential
9191

@@ -100,7 +100,7 @@ Accept wildcard characters: False
100100
Shows all Peering resource by Kind.
101101
102102
```yaml
103-
Type: String
103+
Type: System.String
104104
Parameter Sets: BySubscription
105105
Aliases:
106106

@@ -115,7 +115,7 @@ Accept wildcard characters: False
115115
The unique name of the PSPeering.
116116
117117
```yaml
118-
Type: String
118+
Type: System.String
119119
Parameter Sets: PeeringByResourceAndName
120120
Aliases:
121121

@@ -130,7 +130,7 @@ Accept wildcard characters: False
130130
The resource group name.
131131
132132
```yaml
133-
Type: String
133+
Type: System.String
134134
Parameter Sets: PeeringByResourceAndName
135135
Aliases:
136136

‎src/Peering/Peering/help/Get-AzPeeringLocation.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ Gets the exchange peering location for peering facility id 71.
9292
The credentials, account, tenant, and subscription used for communication with Azure.
9393

9494
```yaml
95-
Type: IAzureContextContainer
95+
Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.Core.IAzureContextContainer
9696
Parameter Sets: (All)
9797
Aliases: AzContext, AzureRmContext, AzureCredential
9898

@@ -107,7 +107,7 @@ Accept wildcard characters: False
107107
Shows all Peering resource by Kind.
108108
109109
```yaml
110-
Type: String
110+
Type: System.String
111111
Parameter Sets: (All)
112112
Aliases:
113113

@@ -122,7 +122,7 @@ Accept wildcard characters: False
122122
The PeeringDB.com Facility ID
123123
124124
```yaml
125-
Type: Int32
125+
Type: System.Int32
126126
Parameter Sets: LocationByFacilityId
127127
Aliases:
128128

@@ -137,7 +137,7 @@ Accept wildcard characters: False
137137
The location of the resource.
138138
139139
```yaml
140-
Type: String
140+
Type: System.String
141141
Parameter Sets: PeeringByKind
142142
Aliases:
143143

‎src/Peering/Peering/help/New-AzPeerAsn.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Creates a new PeerAsn
4343
Run in the background.
4444

4545
```yaml
46-
Type: SwitchParameter
46+
Type: System.Management.Automation.SwitchParameter
4747
Parameter Sets: (All)
4848
Aliases:
4949

@@ -58,7 +58,7 @@ Accept wildcard characters: False
5858
The credentials, account, tenant, and subscription used for communication with Azure.
5959
6060
```yaml
61-
Type: IAzureContextContainer
61+
Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.Core.IAzureContextContainer
6262
Parameter Sets: (All)
6363
Aliases: AzContext, AzureRmContext, AzureCredential
6464

@@ -73,7 +73,7 @@ Accept wildcard characters: False
7373
Email
7474
7575
```yaml
76-
Type: String[]
76+
Type: System.String[]
7777
Parameter Sets: (All)
7878
Aliases:
7979

@@ -88,7 +88,7 @@ Accept wildcard characters: False
8888
The unique name of the PSPeering.
8989
9090
```yaml
91-
Type: String
91+
Type: System.String
9292
Parameter Sets: (All)
9393
Aliases:
9494

@@ -104,7 +104,7 @@ The Peer Asn Resource Id.
104104
Use Get-AzPeerAsn to retrieve the Id.
105105
106106
```yaml
107-
Type: Int32
107+
Type: System.Int32
108108
Parameter Sets: (All)
109109
Aliases:
110110

@@ -119,7 +119,7 @@ Accept wildcard characters: False
119119
The unique name of the PSPeering.
120120
121121
```yaml
122-
Type: String
122+
Type: System.String
123123
Parameter Sets: (All)
124124
Aliases:
125125

@@ -134,7 +134,7 @@ Accept wildcard characters: False
134134
Phone
135135
136136
```yaml
137-
Type: String[]
137+
Type: System.String[]
138138
Parameter Sets: (All)
139139
Aliases:
140140

@@ -149,7 +149,7 @@ Accept wildcard characters: False
149149
Prompts you for confirmation before running the cmdlet.
150150
151151
```yaml
152-
Type: SwitchParameter
152+
Type: System.Management.Automation.SwitchParameter
153153
Parameter Sets: (All)
154154
Aliases: cf
155155

@@ -164,7 +164,7 @@ Accept wildcard characters: False
164164
Shows what would happen if the cmdlet runs. The cmdlet is not run.
165165
166166
```yaml
167-
Type: SwitchParameter
167+
Type: System.Management.Automation.SwitchParameter
168168
Parameter Sets: (All)
169169
Aliases: wi
170170

0 commit comments

Comments
 (0)