Skip to content

Commit 1f3b0d4

Browse files
author
Milos Todic
committed
Addressing comments.
1 parent 0dc8943 commit 1f3b0d4

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

src/Sql/Sql/VirtualCluster/Cmdlet/GetAzureSqlVirtualCluster.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ public class GetAzureSqlVirtualCluster : VirtualClusterCmdletBase
5454
HelpMessage = "The name of the resource group.")]
5555
[Parameter(ParameterSetName = GetByResourceGroupParameterSet,
5656
Mandatory = false,
57-
Position = 1,
5857
HelpMessage = "The name of the resource group.")]
5958
[ResourceGroupCompleter]
6059
[ValidateNotNullOrEmpty]

src/Sql/Sql/VirtualCluster/Cmdlet/RemoveAzureSqlVirtualCluster.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ public class RemoveAzureSqlManagedInstance : VirtualClusterCmdletBase
7777
/// </summary>
7878
[Parameter(ParameterSetName = RemoveByResourceIdParameterSet,
7979
Mandatory = true,
80-
Position = 0,
8180
ValueFromPipelineByPropertyName = true,
8281
HelpMessage = "The resource id of instance object to remove")]
8382
[ValidateNotNullOrEmpty]

src/Sql/Sql/VirtualCluster/Services/AzureSqlVirtualClusterAdapter.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
1616
using Microsoft.Azure.Commands.ResourceManager.Common.Tags;
1717
using Microsoft.Azure.Commands.Sql.VirtualCluster.Model;
18+
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
1819
using System.Collections.Generic;
1920
using System.Linq;
2021

@@ -99,10 +100,8 @@ private static AzureSqlVirtualClusterModel CreateVirtualClusterModelFromResponse
99100
AzureSqlVirtualClusterModel virtualCluster = new AzureSqlVirtualClusterModel();
100101

101102
// Extract the resource group name from the ID.
102-
// ID is in the form:
103-
// /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rgName/providers/Microsoft.Sql/virtualClusters/virtualClusterName
104-
string[] segments = resp.Id.Split('/');
105-
virtualCluster.ResourceGroupName = segments[4];
103+
ResourceIdentifier resourceIdentifier = new ResourceIdentifier(resp.Id);
104+
virtualCluster.ResourceGroupName = resourceIdentifier.ResourceGroupName;
106105

107106
virtualCluster.VirtualClusterName = resp.Name;
108107
virtualCluster.Id = resp.Id;

src/Sql/Sql/help/Remove-AzSqlVirtualCluster.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Remove-AzSqlVirtualCluster [-InputObject] <AzureSqlVirtualClusterModel> [-AsJob]
2626

2727
### RemoveVirtualClusterFromAzureResourceId
2828
```
29-
Remove-AzSqlVirtualCluster [-ResourceId] <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
29+
Remove-AzSqlVirtualCluster -ResourceId <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
3030
[-Confirm] [<CommonParameters>]
3131
```
3232

@@ -128,7 +128,7 @@ Parameter Sets: RemoveVirtualClusterFromAzureResourceId
128128
Aliases:
129129

130130
Required: True
131-
Position: 0
131+
Position: Named
132132
Default value: None
133133
Accept pipeline input: True (ByPropertyName)
134134
Accept wildcard characters: False

0 commit comments

Comments
 (0)