Skip to content

Commit 2de4b04

Browse files
aygoyaaygoya
committed
typo, unused imports. - enable severity, status tests. update properties count( since prod outage was removed). add tests for ticket status.
1 parent 358e1cf commit 2de4b04

File tree

3 files changed

+75
-29
lines changed

3 files changed

+75
-29
lines changed

‎src/Support/Support.Test/ScenarioTests/SupportTicketTests.cs

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,8 @@
1313
// ----------------------------------------------------------------------------------
1414

1515
using Microsoft.Azure.Commands.ScenarioTest;
16-
using Microsoft.Azure.Management.Internal.Resources;
17-
using Microsoft.Azure.Management.Internal.Resources.Models;
1816
using Microsoft.Azure.ServiceManagement.Common.Models;
19-
using Microsoft.Rest.Azure.OData;
2017
using Microsoft.WindowsAzure.Commands.ScenarioTest;
21-
using System.Linq;
2218
using Xunit;
2319

2420
namespace Microsoft.Azure.Commands.Support.Test.ScenarioTests
@@ -124,5 +120,19 @@ public void UpdateAzSupportTicketNameParameterSetWithContactDetail()
124120
{
125121
TestController.NewInstance.RunPowerShellTest(_logger, "Update-AzSupportTicketNameParameterSetWithContactDetail");
126122
}
123+
124+
[Fact]
125+
[Trait(Category.AcceptanceType, Category.CheckIn)]
126+
public void UpdateAzSupportTicketParentObjectParameterSetUpdateSeverity()
127+
{
128+
TestController.NewInstance.RunPowerShellTest(_logger, "Update-AzSupportTicketParentObjectParameterSetUpdateSeverity");
129+
}
130+
131+
[Fact]
132+
[Trait(Category.AcceptanceType, Category.CheckIn)]
133+
public void UpdateAzSupportTicketParentObjectParameterSetUpdateStatus()
134+
{
135+
TestController.NewInstance.RunPowerShellTest(_logger, "Update-AzSupportTicketParentObjectParameterSetUpdateSeverity");
136+
}
127137
}
128138
}

‎src/Support/Support.Test/ScenarioTests/SupportTicketTests.ps1

Lines changed: 60 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Get support ticket by name parameter set
1818
#>
1919
function Get-AzSupportTicketByNameParameterSet
2020
{
21-
$propertiesCount = 24
21+
$propertiesCount = 23
2222
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
2323

2424
$queryResult = Get-AzSupportTicket -First 1
@@ -38,13 +38,13 @@ Get support tickets filtered by status
3838
#>
3939
function Get-AzSupportTicketFilterByStatus
4040
{
41-
$propertiesCount = 24
41+
$propertiesCount = 23
4242
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
4343

4444
$queryResult = Get-AzSupportTicket -First 1 -Filter "Status eq 'Closed'"
4545
Assert-NotNull $queryResult
4646
Assert-AreEqual 1 $queryResult.Count
47-
47+
4848
for ($i = 0; $i -lt $queryResult.Count; $i++)
4949
{
5050
Assert-IsInstance $queryResult[$i] $cmdletReturnType
@@ -60,7 +60,7 @@ Get support tickets using paging parameter
6060
#>
6161
function Get-AzSupportTicketPagingParameters
6262
{
63-
$propertiesCount = 24
63+
$propertiesCount = 23
6464
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
6565

6666
$queryResult = Get-AzSupportTicket -First 1 -Skip 1
@@ -81,9 +81,9 @@ New support ticket
8181
#>
8282
function New-AzSupportTicketWithContactObject
8383
{
84-
$result = New-SupportTicketWith24X7Response
84+
$result = New-SupportTicketWith24X7Response
8585

86-
$propertiesCount = 24
86+
$propertiesCount = 23
8787
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
8888
Assert-NotNull $result
8989
Assert-IsInstance $result $cmdletReturnType
@@ -118,14 +118,14 @@ function New-AzSupportTicketQuotaWithContactObject
118118
$quotaChangeRequest = new-object Microsoft.Azure.Commands.Support.Models.PSQuotaChangeRequest
119119
$quotaChangeRequest.Region = "EastUS"
120120
$quotaChangeRequest.Payload = "{`"VMFamily`":`"Dv2 Series`",`"NewLimit`":516}"
121-
121+
122122
$quotaTicketDetail = new-object Microsoft.Azure.Commands.Support.Models.PSQuotaTicketDetail
123123
$quotaTicketDetail.QuotaChangeRequestVersion = "1.0"
124-
$quotaTicketDetail.QuotaChangeRequests = @($quotaChangeRequest)
124+
$quotaTicketDetail.QuotaChangeRequests = @($quotaChangeRequest)
125125

126126
$result = New-SupportTicketWith24X7Response -serviceDisplayName "Service and subscription limits" -problemClassificationDisplayName "Compute" -quotaTicketDetails $quotaTicketDetail
127127

128-
$propertiesCount = 24
128+
$propertiesCount = 23
129129
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
130130
Assert-NotNull $result
131131
Assert-IsInstance $result $cmdletReturnType
@@ -147,7 +147,7 @@ function New-AzSupportTicketTechnicalWithContactObject
147147
$resource = Get-AzureRmResource -ResourceType "Microsoft.Compute/virtualMachines"
148148
$result = New-SupportTicketWith24X7Response -serviceDisplayName "Virtual Machine" -technicalTicketResourceId $resource[0].Id
149149

150-
$propertiesCount = 24
150+
$propertiesCount = 23
151151
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
152152
Assert-NotNull $result
153153
Assert-IsInstance $result $cmdletReturnType
@@ -163,9 +163,9 @@ New support ticket
163163
#>
164164
function New-AzSupportTicketWithContactDetail
165165
{
166-
$result = New-SupportTicketWithContactDetail
166+
$result = New-SupportTicketWithContactDetail
167167

168-
$propertiesCount = 24
168+
$propertiesCount = 23
169169
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
170170
Assert-NotNull $result
171171
Assert-IsInstance $result $cmdletReturnType
@@ -203,11 +203,11 @@ function New-AzSupportTicketQuotaWithContactDetail
203203

204204
$quotaTicketDetail = new-object Microsoft.Azure.Commands.Support.Models.PSQuotaTicketDetail
205205
$quotaTicketDetail.QuotaChangeRequestVersion = "1.0"
206-
$quotaTicketDetail.QuotaChangeRequests = @($quotaChangeRequest)
206+
$quotaTicketDetail.QuotaChangeRequests = @($quotaChangeRequest)
207207

208208
$result = New-SupportTicketWithContactDetail -serviceDisplayName "Service and subscription limits" -problemClassificationDisplayName "Compute" -quotaTicketDetails $quotaTicketDetail
209209

210-
$propertiesCount = 24
210+
$propertiesCount = 23
211211
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
212212
Assert-NotNull $result
213213
Assert-IsInstance $result $cmdletReturnType
@@ -227,10 +227,10 @@ New technical support ticket
227227
function New-AzSupportTicketTechnicalWithContactDetail
228228
{
229229
$resource = Get-AzureRmResource -ResourceType Microsoft.Compute/virtualMachines
230-
230+
231231
$result = New-SupportTicketWithContactDetail -serviceDisplayName "Virtual Machine" -technicalTicketResourceId $resource[0].Id
232232

233-
$propertiesCount = 24
233+
$propertiesCount = 23
234234
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
235235
Assert-NotNull $result
236236
Assert-IsInstance $result $cmdletReturnType
@@ -248,7 +248,7 @@ function New-AzSupportTicketCspWithContactObject
248248
{
249249
$result = New-CspSupportTicket -CSPHomeTenantId "8465bc54-690d-4169-b3fd-dc47631637c2"
250250

251-
$propertiesCount = 24
251+
$propertiesCount = 23
252252
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
253253
Assert-NotNull $result
254254
Assert-IsInstance $result $cmdletReturnType
@@ -274,7 +274,7 @@ function Update-AzSupportTicketParentObjectParameterSetWithContactObject
274274
$contactDetail.AdditionalEmailAddresses = @("[email protected]")
275275
$updateTicket = $newTicket | Update-AzSupportTicket -CustomerContactDetail $contactDetail
276276

277-
$propertiesCount = 24
277+
$propertiesCount = 23
278278
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
279279
Assert-NotNull $updateTicket
280280
Assert-IsInstance $updateTicket $cmdletReturnType
@@ -297,9 +297,9 @@ Update support ticket by parent object paremeter set with contact object
297297
function Update-AzSupportTicketParentObjectParameterSetUpdateSeverity
298298
{
299299
$newTicket = New-SupportTicketWithContactDetail
300-
$updateTicket = $newTicket | Update-AzSupportTicket -Severity "Critical"
300+
$updateTicket = $newTicket | Update-AzSupportTicket -Severity "Critical"
301301

302-
$propertiesCount = 24
302+
$propertiesCount = 23
303303
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
304304
Assert-NotNull $updateTicket
305305
Assert-IsInstance $updateTicket $cmdletReturnType
@@ -308,6 +308,24 @@ function Update-AzSupportTicketParentObjectParameterSetUpdateSeverity
308308
Assert-AreEqual "critical" $updateTicket.Severity.ToLower()
309309
}
310310

311+
<#
312+
.SYNOPSIS
313+
Update support ticket by parent object paremeter set with contact object
314+
#>
315+
function Update-AzSupportTicketParentObjectParameterSetUpdateStatus
316+
{
317+
$newTicket = New-SupportTicketWithContactDetail
318+
$updateTicket = $newTicket | Update-AzSupportTicket -Status "Closed"
319+
320+
$propertiesCount = 23
321+
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
322+
Assert-NotNull $updateTicket
323+
Assert-IsInstance $updateTicket $cmdletReturnType
324+
Assert-PropertiesCount $updateTicket $propertiesCount
325+
Assert-IsInstance $updateTicket.Name String
326+
Assert-AreEqual "closed" $updateTicket.Severity.ToLower()
327+
}
328+
311329
<#
312330
.SYNOPSIS
313331
Update support ticket by name parameter set with contact object
@@ -320,7 +338,7 @@ function Update-AzSupportTicketNameParameterSetWithContactObject
320338
$contactDetail.LastName = "last updated"
321339
$updateTicket = Update-AzSupportTicket -Name $newTicket.Name -CustomerContactDetail $contactDetail
322340

323-
$propertiesCount = 24
341+
$propertiesCount = 23
324342
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
325343
Assert-NotNull $updateTicket
326344
Assert-IsInstance $updateTicket $cmdletReturnType
@@ -339,7 +357,7 @@ function Update-AzSupportTicketNameParameterSetUpdateSeverity
339357
$newTicket = New-SupportTicketWithContactDetail
340358
$updateTicket = Update-AzSupportTicket -Name $newTicket.Name -Severity "Critical"
341359

342-
$propertiesCount = 24
360+
$propertiesCount = 23
343361
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
344362
Assert-NotNull $updateTicket
345363
Assert-IsInstance $updateTicket $cmdletReturnType
@@ -348,6 +366,24 @@ function Update-AzSupportTicketNameParameterSetUpdateSeverity
348366
Assert-AreEqual "critical" $updateTicket.Severity.ToLower()
349367
}
350368

369+
<#
370+
.SYNOPSIS
371+
Update support ticket by name parameter set with contact object
372+
#>
373+
function Update-AzSupportTicketNameParameterSetUpdateStatus
374+
{
375+
$newTicket = New-SupportTicketWithContactDetail
376+
$updateTicket = Update-AzSupportTicket -Name $newTicket.Name -Status "Closed"
377+
378+
$propertiesCount = 23
379+
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
380+
Assert-NotNull $updateTicket
381+
Assert-IsInstance $updateTicket $cmdletReturnType
382+
Assert-PropertiesCount $updateTicket $propertiesCount
383+
Assert-IsInstance $updateTicket.Name String
384+
Assert-AreEqual "closed" $updateTicket.Status.ToLower()
385+
}
386+
351387
<#
352388
.SYNOPSIS
353389
Update support ticket by parent object paremeter set with contact detail
@@ -357,7 +393,7 @@ function Update-AzSupportTicketParentObjectParameterSetWithContactDetail
357393
$newTicket = New-SupportTicketWithContactDetail
358394
$updateTicket = $newTicket | Update-AzSupportTicket -CustomerFirstName "first updated" -CustomerLastName "last updated" -CustomerPrimaryEmailAddress "[email protected]" -CustomerCountry "IND" -CustomerPreferredTimeZone "Eastern Standard Time" -CustomerPreferredSupportLanguage "ja-jp" -AdditionalEmailAddress @("[email protected]")
359395

360-
$propertiesCount = 24
396+
$propertiesCount = 23
361397
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
362398
Assert-NotNull $updateTicket
363399
Assert-IsInstance $updateTicket $cmdletReturnType
@@ -382,7 +418,7 @@ function Update-AzSupportTicketNameParameterSetWithContactDetail
382418
$newTicket = New-SupportTicketWithContactDetail
383419
$updateTicket = Update-AzSupportTicket -Name $newTicket.Name -CustomerFirstName "first updated" -CustomerLastName "last updated" -CustomerPrimaryEmailAddress "[email protected]" -CustomerCountry "IND" -CustomerPreferredTimeZone "Eastern Standard Time" -CustomerPreferredSupportLanguage "ja-jp" -AdditionalEmailAddress @("[email protected]")
384420

385-
$propertiesCount = 24
421+
$propertiesCount = 23
386422
$cmdletReturnType = "Microsoft.Azure.Commands.Support.Models.PSSupportTicket"
387423
Assert-NotNull $updateTicket
388424
Assert-IsInstance $updateTicket $cmdletReturnType

‎src/Support/Support/Helpers/ModelExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public static PSSupportProblemClassification ToPSSupportProblemClassification(th
4444
Id = sdkProblemClassification.Id,
4545
Name = sdkProblemClassification.Name,
4646
Type = sdkProblemClassification.Type,
47-
DisplayName = sdkProblemClassification.DisplayName,
47+
DisplayName = sdkProblemClassification.DisplayName
4848
};
4949
}
5050

0 commit comments

Comments
 (0)