Merge branch 'master' into get-azure-resource-cmdlet-cs

Author: jagilber

.azure-pipelines/powershell-core.yml

@@ -4,7 +4,7 @@ variables:
   LinuxName: linux
   LinuxImage: ubuntu-18.04
   MacOSName: macOS
-  MacOSImage: macOS-10.13
+  MacOSImage: macOS-10.14
   TestFramework: netcoreapp2.2
   TestTarget: Test
   Configuration: Debug

docker/README.md

@@ -15,7 +15,7 @@ Please follow [Docker's official instructions][install] to install `docker` corr
 
 ## Release
 
-The release containers derive from the [Powershell image][powershell image], and then install the current Az package.
+The release containers derive from the [Powershell image][powershell image], and then install the current Az package. The current images are using PowerShell 6.2.4, we are planning to add support for PowerShell 7 in the near future.
 
 [powershell image]: https://hub.docker.com/_/microsoft-powershell
 
@@ -99,4 +99,4 @@ For more information see the [Code of Conduct FAQ][conduct-FAQ] or contact [open
 
 [conduct-code]: http://opensource.microsoft.com/codeofconduct/
 [conduct-FAQ]: http://opensource.microsoft.com/codeofconduct/faq/
-[conduct-email]: mailto:[email protected]
+[conduct-email]: mailto:[email protected]

documentation/development-docs/azure-powershell-developer-guide.md

@@ -2,6 +2,8 @@
 
 The Azure PowerShell Developer Guide was created to help with the development and testing of Azure PowerShell cmdlets. This guide contains information on how to set up your environment, create a new project, implement cmdlets, record and run tests, and more.
 
+**Note: Except for the way described in this page, There is a new way to generate PowerShell modules through AutoRest PowerShell generator. And related links are attached in the end.**
+
 # Table of Contents
 
 - [Prerequisites](#prerequisites)
@@ -36,6 +38,7 @@ The Azure PowerShell Developer Guide was created to help with the development an
 - [After Development](#after-development)
 - [Misc](#misc)
     - [Publish to PowerShell Gallery](#publish-to-powershell-gallery)
+- [Autorest PowerShell Generator](#autorest-powershell-generator)
 
 # Prerequisites
 
@@ -317,3 +320,7 @@ Whenever you make updates to a project, please make sure to update the correspon
 ## Publish to PowerShell Gallery
 
 To publish your module to the [official PowerShell gallery](http://www.powershellgallery.com/) or the test gallery site, contact the Azure PowerShell team
+
+# AutoRest PowerShell Generator
+- [autorest.powershell documentation](https://github.com/Azure/autorest.powershell/tree/master/docs)
+- [examples](https://github.com/Azure/azure-powershell/tree/generation/src)

src/Accounts/Accounts/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fix Get-AzTenant/Get-AzDefault/Set-AzDefault throw NullReferenceException when not login
 
 ## Version 1.7.3
 * Open Azure PowerShell survey page in `Send-Feedback` [#11020]

src/Accounts/Accounts/Default/ClearAzureRmDefault.cs

@@ -46,7 +46,7 @@ public override void ExecuteCmdlet()
                 throw new Exception("Default Resource Group cannot be set on CloudShell");
             }
 
-            IAzureContext context = AzureRmProfileProvider.Instance.Profile.DefaultContext;
+            IAzureContext context = DefaultContext;
             // If no parameters are specified, clear all defaults
             if (!ResourceGroup)
             {

src/Accounts/Accounts/Default/GetAzureRmDefault.cs

@@ -37,7 +37,7 @@ public class GetAzureRMDefaultCommand : AzureRMCmdlet
 
         public override void ExecuteCmdlet()
         {
-            IAzureContext context = AzureRmProfileProvider.Instance.Profile.DefaultContext;
+            IAzureContext context = DefaultContext;
             IResourceManagementClient client = AzureSession.Instance.ClientFactory.CreateCustomArmClient<ResourceManagementClient>(
                                     context.Environment.GetEndpointAsUri(AzureEnvironment.Endpoint.ResourceManager),
                                     AzureSession.Instance.AuthenticationFactory.GetServiceClientCredentials(context, AzureEnvironment.Endpoint.ResourceManager),

src/Accounts/Accounts/Default/SetAzureRMDefault.cs

@@ -50,7 +50,7 @@ public override void ExecuteCmdlet()
                 throw new Exception("Default Resource Group cannot be set on CloudShell");
             }
 
-            IAzureContext context = AzureRmProfileProvider.Instance.Profile.DefaultContext;
+            IAzureContext context = DefaultContext;
             IResourceManagementClient resourceManagementclient = AzureSession.Instance.ClientFactory.CreateCustomArmClient<ResourceManagementClient>(
                                 context.Environment.GetEndpointAsUri(AzureEnvironment.Endpoint.ResourceManager),
                                 AzureSession.Instance.AuthenticationFactory.GetServiceClientCredentials(context, AzureEnvironment.Endpoint.ResourceManager),

src/Accounts/Accounts/Models/RMProfileClient.cs

@@ -41,6 +41,18 @@ public class RMProfileClient
         private IAzureTokenCache _cache;
         public Action<string> WarningLog;
 
+        private IAzureContext DefaultContext
+        {
+            get
+            {
+                if(_profile == null || _profile.DefaultContext == null || _profile.DefaultContext.Account == null)
+                {
+                    throw new PSInvalidOperationException(ResourceMessages.RunConnectAccount);
+                }
+                return _profile.DefaultContext;
+            }
+        }
+
         public RMProfileClient(IProfileOperations profile)
         {
             _profile = profile;
@@ -368,7 +380,7 @@ public List<AzureTenant> ListTenants(string tenant = "")
                 return new List<AzureTenant>() { CreateTenant(tenant) };
             }
 
-            List<AzureTenant> tenants = ListAccountTenants(_profile.DefaultContext.Account, _profile.DefaultContext.Environment, null, ShowDialog.Never, null);
+            List<AzureTenant> tenants = ListAccountTenants(DefaultContext.Account, DefaultContext.Environment, null, ShowDialog.Never, null);
             return tenants.Where(t => string.IsNullOrEmpty(tenant) ||
                                          tenant.Equals(t.Id.ToString(), StringComparison.OrdinalIgnoreCase) ||
                                          tenant.Equals(t.Directory, StringComparison.OrdinalIgnoreCase))

src/DataLakeStore/DataLakeStore.Test/ScenarioTests/AdlsTests.cs

@@ -66,7 +66,7 @@ public void TestAdlsAccountTiers()
             NewInstance.RunPsTest(_logger, string.Format("Test-DataLakeStoreAccountTiers -location '{0}'", AdlsTestsBase.ResourceGroupLocation));
         }
 
-        [Fact]
+        [Fact(Skip="This case has been unstable on Linux for approximately 20% of failure. Needs investigation.")]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestAdlsFileSystem()
         {

src/IotCentral/IotCentral.Test/IotCentral.Test.csproj

@@ -11,7 +11,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.IotCentral" Version="2.1.0" />
+    <PackageReference Include="Microsoft.Azure.Management.IotCentral" Version="2.2.0" />
   </ItemGroup>
 
 </Project>