put parser into helper

Author: yifanz7

src/Storage/Storage.Management/StorageAccount/RestoreAzStorageBlobRange.cs

@@ -135,11 +135,15 @@ public override void ExecuteCmdlet()
                     // The workaround is to get the raw response and parse it into the output desired
                     // The Blob restore status should be got from SDK directly once the issue is fixed
                     Dictionary<string, object> temp = restoreLro.GetRawResponse().Content.ToObjectFromJson() as Dictionary<string, object>;
-                    object restoreId;
 
-                    if (temp != null && temp.TryGetValue("restoreId", out restoreId))
+                    if (temp == null)
+                    {
+                        throw new InvalidJobStateException("Could not fetch the Blob restore response.");
+                    }
+                    PSBlobRestoreStatus blobRestoreStatus = ParseRestoreRawResponse(temp);
+                    if (blobRestoreStatus.RestoreId != null)
                     {
-                        WriteWarning(string.Format("Restore blob ranges with Id '{0}' started. Restore blob ranges time to complete is dependent on the size of the restore.", restoreId));
+                        WriteWarning(string.Format("Restore blob ranges with Id '{0}' started. Restore blob ranges time to complete is dependent on the size of the restore.", blobRestoreStatus.RestoreId));
                     }
                     else
                     {
@@ -165,62 +169,77 @@ public override void ExecuteCmdlet()
                             this.TimeToRestore.ToUniversalTime(),
                             PSBlobRestoreRange.ParseBlobRestoreRanges(this.BlobRestoreRange)));
                     Dictionary<string, object> temp = restoreLro.GetRawResponse().Content.ToObjectFromJson() as Dictionary<string, object>;
-                    object jobStatus = null;
 
-                    if (temp != null && temp.TryGetValue("status", out jobStatus))
+                    if (temp == null)
+                    {
+                        throw new InvalidJobStateException("Could not fetch the Blob restore response.");
+                    }
+
+                    PSBlobRestoreStatus blobRestoreStatus = ParseRestoreRawResponse(temp);
+
+                    if (blobRestoreStatus.Status != null)
                     {
-                        if (jobStatus != null && jobStatus.ToString() == Track2Models.BlobRestoreProgressStatus.Failed.ToString())
+                        if (blobRestoreStatus.Status == Track2Models.BlobRestoreProgressStatus.Failed.ToString())
                         {
                             throw new InvalidJobStateException("Blob ranges restore failed.");
                         }
-                    } else
+                    } 
+                    else
                     {
                         WriteWarning(string.Format("Could not fetch the status."));
                     }
+                    WriteObject(blobRestoreStatus);
+                }
+            }
+        }
 
-                    if (temp == null)
-                    {
-                        throw new InvalidJobStateException("Could not fetch the Blob restore response.");
-                    }
+        private PSBlobRestoreStatus ParseRestoreRawResponse(Dictionary<string, object> response)
+        {
+            response.TryGetValue("restoreId", out object restoreId);
+            response.TryGetValue("status", out object jobStatus);
+            response.TryGetValue("parameters", out object parameters);
 
-                    temp.TryGetValue("restoreId", out object restoreId);
-                    temp.TryGetValue("parameters", out object parameters);
+            PSBlobRestoreParameters blobRestoreParameters;
+            Dictionary<string, object> paramMap = parameters as Dictionary<string, object>;
 
-                    PSBlobRestoreParameters blobRestoreParameters = new PSBlobRestoreParameters();
-                    Dictionary<string, object> paramMap = parameters as Dictionary<string, object>;
+            if (paramMap == null)
+            {
+                blobRestoreParameters = null;
+            }
+            else
+            {
+                blobRestoreParameters = new PSBlobRestoreParameters();
+                paramMap.TryGetValue("timetoRestore", out object timeToRestore);
+                DateTimeOffset.TryParse(timeToRestore?.ToString(), out DateTimeOffset parseDate);
+                blobRestoreParameters.TimeToRestore = parseDate;
 
-                    paramMap.TryGetValue("timetoRestore", out object timeToRestore);
-                    DateTimeOffset.TryParse(timeToRestore.ToString(), out DateTimeOffset parseDate);
-                    blobRestoreParameters.TimeToRestore = parseDate;
+                paramMap.TryGetValue("blobRanges", out object ranges);
+                List<PSBlobRestoreRange> blobRestoreRanges = new List<PSBlobRestoreRange>();
 
-                    paramMap.TryGetValue("blobRanges", out object ranges);
-                    List<PSBlobRestoreRange> blobRestoreRanges = new List<PSBlobRestoreRange>();
-                    
-                    object[] rangesList = ranges as object[];
-                    foreach(object range in rangesList)
-                    {
-                        Dictionary<string, object> rangeMap = range as Dictionary<string, object>;
-                        
-                        rangeMap.TryGetValue("startRange", out object startRange);
-                        rangeMap.TryGetValue("endRange", out object endRange);
+                object[] rangesList = ranges as object[];
+                foreach (object range in rangesList)
+                {
+                    Dictionary<string, object> rangeMap = range as Dictionary<string, object>;
 
-                        PSBlobRestoreRange blobRestoreRange = new PSBlobRestoreRange
-                        {
-                            StartRange = startRange?.ToString(),
-                            EndRange = endRange?.ToString()
-                        };
+                    rangeMap.TryGetValue("startRange", out object startRange);
+                    rangeMap.TryGetValue("endRange", out object endRange);
 
-                        blobRestoreRanges.Add(blobRestoreRange);
-                    }
-                    blobRestoreParameters.BlobRanges = blobRestoreRanges.ToArray();
+                    PSBlobRestoreRange blobRestoreRange = new PSBlobRestoreRange
+                    {
+                        StartRange = startRange?.ToString(),
+                        EndRange = endRange?.ToString()
+                    };
 
-                    WriteObject(new PSBlobRestoreStatus(
-                        status: jobStatus?.ToString(),
-                        failureReason: null,
-                        restoreId: restoreId?.ToString(),
-                        blobRestoreParameters));
+                    blobRestoreRanges.Add(blobRestoreRange);
                 }
+                blobRestoreParameters.BlobRanges = blobRestoreRanges.ToArray();
             }
+
+            return new PSBlobRestoreStatus(
+                status: jobStatus?.ToString(),
+                failureReason: null,
+                restoreId: restoreId?.ToString(),
+                parameters: blobRestoreParameters);
         }
     }
 }