Skip to content

Commit 4df6b4c

Browse files
committed
add release.props for docker image versions
1 parent 533c8d2 commit 4df6b4c

File tree

4 files changed

+19
-5
lines changed

4 files changed

+19
-5
lines changed

build.proj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@
244244

245245
<Target Name="BuildImage">
246246
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(DockerTools)/GetArtifacts.ps1 -Artifacts $(RepoArtifacts) -Docker $(DockerRoot) &quot;" />
247-
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(DockerTools)/BuildImages.ps1 -DOCKER $(DockerRoot) -IMAGENAME $(DockerImageName) &quot;" />
247+
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(DockerTools)/BuildImages.ps1 -DOCKER $(DockerRoot) -DockerImageName $(DockerImageName) &quot;" />
248248
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(DockerTools)/CleanArtifacts.ps1 -Docker $(DockerRoot) &quot;" />
249249
</Target>
250250

docker/config/release.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
az.version=3.3.0

tools/RunVersionController.ps1

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,19 @@ function Update-ChangeLog
154154
($Content + $ChangeLogContent) | Set-Content -Path $ChangeLogFile.FullName -Encoding UTF8
155155
}
156156

157+
function Update-Image-Releases
158+
{
159+
Param(
160+
[Parameter(Mandatory = $true)]
161+
[string]$ReleaseProps,
162+
[Parameter(Mandatory = $true)]
163+
[string]$AzVersion
164+
)
165+
166+
$content = Get-Content $ReleaseProps
167+
$content -Replace "az.version=\d+\.\d+\.\d+", "az.version=$AzVersion" | Set-Content $ReleaseProps
168+
}
169+
157170
function Get-ExistSerializedCmdletJsonFile
158171
{
159172
return $(ls "$PSScriptRoot\Tools.Common\SerializedCmdlets").Name
@@ -287,5 +300,6 @@ switch ($PSCmdlet.ParameterSetName)
287300

288301
Update-ModuleManifest -Path "$PSScriptRoot\Az\Az.psd1" -ModuleVersion $newVersion -ReleaseNotes $releaseNotes
289302
Update-ChangeLog -Content $changeLog -RootPath $rootPath
303+
Update-Image-Releases -ReleaseProps "$rootPath\docker\config\release.props" -AzVersion $newVersion
290304
}
291305
}

tools/docker/BuildImages.ps1

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,16 @@ param(
1616
[string]$DOCKER,
1717

1818
[Parameter(Mandatory = $true)]
19-
[string]$IMAGENAME
19+
[string]$DockerImageName
2020
)
2121

22-
##TODO:read version from file
23-
$version = 12345
22+
$version = (Get-Content "$DOCKER/config/release.props" | Select-String "az.version").ToString().Split("=")[1]
2423

2524
try {
2625
foreach ($dockerfile in (Get-ChildItem -Path $DOCKER -Filter "Dockerfile-*").FullName) {
2726
$os = $dockerfile.split("Dockerfile-")[1]
2827
Write-Output $os
29-
docker build -t $IMAGENAME':'$version"-"$os -f $dockerfile $DOCKER
28+
docker build --build-arg VERSION=$version -t $DockerImageName':'$version"-"$os -f $dockerfile $DOCKER
3029
}
3130
} catch {
3231
$Errors = $_

0 commit comments

Comments
 (0)