Documented PSPolicySigners return type, fixed ShouldProcess logic

Author: gkostal

src/Attestation/Attestation/Commands/AddAzAttestationPolicySigner.cs

@@ -23,7 +23,7 @@ namespace Microsoft.Azure.Commands.Attestation
     /// Set AttestationPolicy.
     /// </summary>
     [Cmdlet("Add", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "AttestationPolicySigner", SupportsShouldProcess = true)]
-    [OutputType(typeof(String))]
+    [OutputType(typeof(PSPolicySigners))]
     public class AddAzureAttestationPolicySigner : AttestationDataServiceCmdletBase
     {
         #region Input Parameter Definitions
@@ -77,9 +77,12 @@ public class AddAzureAttestationPolicySigner : AttestationDataServiceCmdletBase
 
         public override void ExecuteCmdlet()
         {
-            String policySignersString = AttestationDataPlaneClient.AddPolicySigner(Name, ResourceGroupName, ResourceId, Signer);
-            PSPolicySigners policySigners = new PSPolicySigners(policySignersString);
-            WriteObject(policySigners);
+            if (ShouldProcess(Name, "AddAttestationPolicySigner"))
+            {
+                String policySignersString = AttestationDataPlaneClient.AddPolicySigner(Name, ResourceGroupName, ResourceId, Signer);
+                PSPolicySigners policySigners = new PSPolicySigners(policySignersString);
+                WriteObject(policySigners);
+            }
         }
     }
 }

src/Attestation/Attestation/Commands/GetAzureAttestationPolicySigners.cs

@@ -22,8 +22,8 @@ namespace Microsoft.Azure.Commands.Attestation
     /// <summary>
     /// Get AttestationPolicy.
     /// </summary>
-    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "AttestationPolicySigners", SupportsShouldProcess = true)]
-    [OutputType(typeof(String))]
+    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "AttestationPolicySigners")]
+    [OutputType(typeof(PSPolicySigners))]
     public class GetAzureAttestationPolicySigners : AttestationDataServiceCmdletBase
     {
         #region Input Parameter Definitions

src/Attestation/Attestation/Commands/RemoveAzAttestationPolicySigner.cs

@@ -23,7 +23,7 @@ namespace Microsoft.Azure.Commands.Attestation
     /// Set AttestationPolicy.
     /// </summary>
     [Cmdlet("Remove", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "AttestationPolicySigner", SupportsShouldProcess = true)]
-    [OutputType(typeof(String))]
+    [OutputType(typeof(PSPolicySigners))]
     public class RemoveAzureAttestationPolicySigner : AttestationDataServiceCmdletBase
     {
         #region Input Parameter Definitions
@@ -77,9 +77,12 @@ public class RemoveAzureAttestationPolicySigner : AttestationDataServiceCmdletBa
 
         public override void ExecuteCmdlet()
         {
-            String policySignersString = AttestationDataPlaneClient.RemovePolicySigner(Name, ResourceGroupName, ResourceId, Signer);
-            PSPolicySigners policySigners = new PSPolicySigners(policySignersString);
-            WriteObject(policySigners);
+            if (ShouldProcess(Name, "RemoveAttestationPolicySigner"))
+            {
+                String policySignersString = AttestationDataPlaneClient.RemovePolicySigner(Name, ResourceGroupName, ResourceId, Signer);
+                PSPolicySigners policySigners = new PSPolicySigners(policySignersString);
+                WriteObject(policySigners);
+            }
         }
     }
 }

src/Attestation/Attestation/help/Add-AzAttestationPolicySigner.md

@@ -1,7 +1,7 @@
 ---
 external help file: Microsoft.Azure.PowerShell.Cmdlets.Attestation.dll-Help.xml
 Module Name: Az.Attestation
-online version:https://docs.microsoft.com/en-us/powershell/module/az.attestation/add-azattestationpolicysigner
+online version: https://docs.microsoft.com/en-us/powershell/module/az.attestation/add-azattestationpolicysigner
 schema: 2.0.0
 ---
 
@@ -155,7 +155,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
 
 ## OUTPUTS
 
-### System.String
+### Microsoft.Azure.Commands.Attestation.Models.PSPolicySigners
 
 ## NOTES
 

src/Attestation/Attestation/help/Get-AzAttestationPolicySigners.md

@@ -1,7 +1,7 @@
 ---
 external help file: Microsoft.Azure.PowerShell.Cmdlets.Attestation.dll-Help.xml
 Module Name: Az.Attestation
-online version:https://docs.microsoft.com/en-us/powershell/module/az.attestation/get-azattestationpolicysigners
+online version: https://docs.microsoft.com/en-us/powershell/module/az.attestation/get-azattestationpolicysigners
 schema: 2.0.0
 ---
 
@@ -15,13 +15,13 @@ Gets the trusted policy signers from a tenant in Azure Attestation.
 ### NameParameterSet
 ```
 Get-AzAttestationPolicySigners [-Name] <String> [-ResourceGroupName] <String>
- [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
 ### ResourceIdParameterSet
 ```
-Get-AzAttestationPolicySigners [-ResourceId] <String> [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
- [-Confirm] [<CommonParameters>]
+Get-AzAttestationPolicySigners [-ResourceId] <String> [-DefaultProfile <IAzureContextContainer>]
+ [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -98,37 +98,6 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
-### -Confirm
-Prompts you for confirmation before running the cmdlet.
-
-```yaml
-Type: System.Management.Automation.SwitchParameter
-Parameter Sets: (All)
-Aliases: cf
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
-### -WhatIf
-Shows what would happen if the cmdlet runs.
-The cmdlet is not run.
-
-```yaml
-Type: System.Management.Automation.SwitchParameter
-Parameter Sets: (All)
-Aliases: wi
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
 ### CommonParameters
 This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
 
@@ -138,7 +107,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
 
 ## OUTPUTS
 
-### System.String
+### Microsoft.Azure.Commands.Attestation.Models.PSPolicySigners
 
 ## NOTES
 

src/Attestation/Attestation/help/Remove-AzAttestationPolicySigner.md

@@ -1,7 +1,7 @@
 ---
 external help file: Microsoft.Azure.PowerShell.Cmdlets.Attestation.dll-Help.xml
 Module Name: Az.Attestation
-online version:https://docs.microsoft.com/en-us/powershell/module/az.attestation/remove-azattestationpolicysigner
+online version: https://docs.microsoft.com/en-us/powershell/module/az.attestation/remove-azattestationpolicysigner
 schema: 2.0.0
 ---
 
@@ -155,7 +155,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
 
 ## OUTPUTS
 
-### System.String
+### Microsoft.Azure.Commands.Attestation.Models.PSPolicySigners
 
 ## NOTES