Merge branch 'master' of https://github.com/Azure/azure-powershell

Author: Bhavin Shah

.azure-pipelines/powershell-core.yml

@@ -4,7 +4,7 @@ variables:
   LinuxName: linux
   LinuxImage: ubuntu-18.04
   MacOSName: macOS
-  MacOSImage: macOS-10.13
+  MacOSImage: macOS-10.14
   TestFramework: netcoreapp2.2
   TestTarget: Test
   Configuration: Debug

ChangeLog.md

@@ -1,9 +1,96 @@
+## 3.6.1 - March 2020
+#### Az.Accounts
+* Open Azure PowerShell survey page in 'Send-Feedback' [#11020]
+* Display Azure PowerShell survey URL in 'Resolve-Error' [#11021]
+* Added Az version in UserAgent
+
+#### Az.ApiManagement
+* Added support for retrieving and configuring Custom Domain on the DeveloperPortal Endpoint [#11007]
+* 'Export-AzApiManagementApi' Added support for downloading Api Definition in Json format [#9987]
+* 'Import-AzApiManagementApi' Added support for importing OpenApi 3.0 definition from Json document
+* 'New-AzApiManagementIdentityProvider' and 'Set-AzApiManagementIdentityProvider' Added support for configuring 'Signin Tenant' for AAD B2C Provider [#9784]
+
+#### Az.DataLakeStore
+* Added reference to System.Buffers explicitly in csproj and psd1.
+
+#### Az.IotHub
+* Added support to manage devices in an Iot Hub. New Cmdlets are:
+	- 'Add-AzIotHubDevice'
+	- 'Get-AzIotHubDevice'
+	- 'Remove-AzIotHubDevice'
+	- 'Set-AzIotHubDevice'
+* Added support to manage modules on a target Iot device in an Iot Hub. New Cmdlets are:
+	- 'Add-AzIotHubModule'
+	- 'Get-AzIotHubModule'
+	- 'Remove-AzIotHubModule'
+	- 'Set-AzIotHubModule'
+* Added cmdlet to get the connection string of a target IoT device in an Iot Hub.
+* Added cmdlet to get the connection string of a module on a target IoT device in an Iot Hub.
+* Added support to get/set parent device of an IoT device. New Cmdlets are:
+    - 'Get-AzIotHubDeviceParent'
+    - 'Set-AzIotHubDeviceParent'
+* Added support to manage device parent-child relationship.
+
+#### Az.Monitor
+* Fixed output value for 'Get-AzMetricDefinition' [#9714]
+
+#### Az.Network
+* Updated Sql Management SDK.
+* Fixed a naming-difference issue in PrivateLinkServiceConnectionState class.
+    - Mapping the field ActionsRequired to ActionRequired.
+* Added PublicNetworkAccess to 'New-AzSqlServer' and 'Set-AzSqlServer'
+
+#### Az.Resources
+* Fixed for null reference bug in 'Get-AzRoleAssignment'
+* Marked switch '-Force' and '-PassThru' optional in 'Remove-AzADGroup' [#10849]
+* Fixed issue that 'MailNickname' doesn't return in 'Remove-AzADGroup' [#11167]
+* Fixed issue that 'Remove-AzADGroup' pipe operation doesn't work [#11171]
+* Fixed for null reference bug in GetAzureRoleAssignmentCommand
+* Added breaking change attributes for upcoming changes to policy cmdlets
+* Updated 'Get-AzResourceGroup' to perform resource group tag filtering on server-side
+* Extended Tag cmdlets to accept -ResourceId
+    - Get-AzTag -ResourceId
+    - New-AzTag -ResourceId
+    - Remove-AzTag -ResourceId
+* Added new Tag cmdlet
+    - Update-AzTag -ResourceId
+* Brought ScopedDeployment from SDK 3.3.0 
+
+#### Az.Sql
+* Added PublicNetworkAccess to 'New-AzSqlServer' and 'Set-AzSqlServer'
+* Added support for Long Term Retention backup configuration for Managed Databases
+    - Get/Set LTR policy on a managed database 
+    - Get LTR backup(s) by managed database, managed instance, or by location 
+    - Remove an LTR backup 
+    - Restore an LTR backup to create a new managed database
+* Added MinimalTlsVersion to New-AzSqlServer and Set-AzSqlServer
+* Added MinimalTlsVersion to New-AzSqlInstance and Set-AzSqlInstance
+* Bumped SQL SDK version for Az.Network
+
+#### Az.Storage
+* Supported AllowProtectedAppendWrite in ImmutabilityPolicy
+    - 'Set-AzRmStorageContainerImmutabilityPolicy'
+* Added breaking change warning message for AzureStorageTable type change in a future release
+    - 'New-AzStorageTable'
+    - 'Get-AzStorageTable'
+
+#### Az.Websites
+* Added Tag parameter for 'New-AzAppServicePlan' and 'Set-AzAppServicePlan'
+* Stop cmdlet execution if an exception is thrown when adding a custom domain to a website
+* Added support to perform operations for App Services not in the same resource group as the App Service Plan
+* Applied access restriction to WebApp/Function in different resource groups
+* Fixed issue to set custom hostnames for WebAppSlots
+
 ## 3.5.0 - February 2020
 ### Highlights since the last major release
 * Updated client side telemetry.
 * Az.IotHub added cmdlets to support to manage devices.
 * Az.SqlVirtualMachine added cmdlets for Availability Group Listener.
 
+#### Az.Resource
+* Fixed bug preventing correct tenant-level resource id generation.
+* Fixed typo.
+
 #### Az.Accounts
 * Added SubscriptionId, TenantId, and execution time into data of client side telemetry
 

VirtualMachineCustomScriptExtensionManagedDisk.json

@@ -15,7 +15,7 @@ Please follow [Docker's official instructions][install] to install `docker` corr
 
 ## Release
 
-The release containers derive from the [Powershell image][powershell image], and then install the current Az package.
+The release containers derive from the [Powershell image][powershell image], and then install the current Az package. The current images are using PowerShell 6.2.4, we are planning to add support for PowerShell 7 in the near future.
 
 [powershell image]: https://hub.docker.com/_/microsoft-powershell
 
@@ -99,4 +99,4 @@ For more information see the [Code of Conduct FAQ][conduct-FAQ] or contact [open
 
 [conduct-code]: http://opensource.microsoft.com/codeofconduct/
 [conduct-FAQ]: http://opensource.microsoft.com/codeofconduct/faq/
-[conduct-email]: mailto:[email protected]
+[conduct-email]: mailto:[email protected]

docker/README.md

@@ -2,6 +2,8 @@
 
 The Azure PowerShell Developer Guide was created to help with the development and testing of Azure PowerShell cmdlets. This guide contains information on how to set up your environment, create a new project, implement cmdlets, record and run tests, and more.
 
+**Note: Except for the way described in this page, There is a new way to generate PowerShell modules through AutoRest PowerShell generator. And related links are attached in the end.**
+
 # Table of Contents
 
 - [Prerequisites](#prerequisites)
@@ -36,6 +38,7 @@ The Azure PowerShell Developer Guide was created to help with the development an
 - [After Development](#after-development)
 - [Misc](#misc)
     - [Publish to PowerShell Gallery](#publish-to-powershell-gallery)
+- [Autorest PowerShell Generator](#autorest-powershell-generator)
 
 # Prerequisites
 
@@ -317,3 +320,7 @@ Whenever you make updates to a project, please make sure to update the correspon
 ## Publish to PowerShell Gallery
 
 To publish your module to the [official PowerShell gallery](http://www.powershellgallery.com/) or the test gallery site, contact the Azure PowerShell team
+
+# AutoRest PowerShell Generator
+- [autorest.powershell documentation](https://github.com/Azure/autorest.powershell/tree/master/docs)
+- [examples](https://github.com/Azure/azure-powershell/tree/generation/src)

documentation/development-docs/azure-powershell-developer-guide.md

@@ -0,0 +1,35 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using Microsoft.WindowsAzure.Commands.ScenarioTest;
+using Xunit;
+using Xunit.Abstractions;
+
+namespace Microsoft.Azure.Commands.Profile.Test
+{
+    public class ErrorResolutionScenarioTests : AccountsTestRunner
+    {
+        public ErrorResolutionScenarioTests(ITestOutputHelper output)
+            : base(output)
+        {
+        }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void WriteInformationInResolveError()
+        {
+            TestRunner.RunTestScript("Test-WriteInformationInResolveError");
+        }
+    }
+}

src/Accounts/Accounts.Test/ErrorResolutionScenarioTests.cs

@@ -0,0 +1,26 @@
+# -----------------------------------------------------------------------------------
+#
+# Copyright Microsoft Corporation
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# http://www.apache.org/licenses/LICENSE-2.0
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ----------------------------------------------------------------------------------
+
+<#
+.SYNOPSIS
+Tests cmdlets surrounding default resource group
+#>
+
+function Test-WriteInformationInResolveError
+{
+    Assert-Throws { Connect-AzAccount -Wrong }
+    $err = Resolve-AzError -Last
+    Assert-AreEqual 1 $err.length
+    Assert-AreEqual "Microsoft.Azure.Commands.Profile.Errors.AzureExceptionRecord" $err[0].GetType().FullName
+}

src/Accounts/Accounts.Test/ErrorResolutionScenarioTests.ps1

@@ -66,7 +66,7 @@ public void HandlesExceptionError()
             var response = new HttpResponseMessage(HttpStatusCode.BadRequest);
             var hyakException = new TestHyakException("exception message", CloudHttpRequestErrorInfo.Create(request), CloudHttpResponseErrorInfo.Create(response))
             {
-                Error = new Hyak.Common.CloudError { Code="HyakCode", Message="HyakError"}
+                Error = new Hyak.Common.CloudError { Code = "HyakCode", Message = "HyakError" }
             };
 
             var autorestException = new Microsoft.Rest.Azure.CloudException("exception message")
@@ -79,16 +79,15 @@ public void HandlesExceptionError()
 
             var cmdlet = new ResolveError
             {
-                Error = new [] 
+                Error = new[]
                 {
                     new ErrorRecord(new Exception("exception message"), "errorCode", ErrorCategory.AuthenticationError, this),
                     new ErrorRecord(hyakException, "errorCode", ErrorCategory.ConnectionError, this),
                     new ErrorRecord(autorestException , "errorCode", ErrorCategory.InvalidOperation, this),
                 },
                 CommandRuntime = runtime
             };
-
-            cmdlet.ExecuteCmdlet();
+            Assert.Throws<NotImplementedException>(() => cmdlet.ExecuteCmdlet());
             Assert.NotNull(runtime.OutputPipeline);
             Assert.Equal(3, runtime.OutputPipeline.Count);
             var errorResult = runtime.OutputPipeline[0] as AzureExceptionRecord;
@@ -130,9 +129,9 @@ public void HandlesNullValuesInArmExceptions()
         {
             var runtime = new MockCommandRuntime();
             var hyakException = new TestHyakException(null, null, null);
- 
+
             var autorestException = new Microsoft.Rest.Azure.CloudException();
- 
+
             var cmdlet = new ResolveError
             {
                 Error = new[]
@@ -143,8 +142,8 @@ public void HandlesNullValuesInArmExceptions()
                 },
                 CommandRuntime = runtime
             };
- 
-            cmdlet.ExecuteCmdlet();
+
+            Assert.Throws<NotImplementedException>(() => cmdlet.ExecuteCmdlet());
             Assert.NotNull(runtime.OutputPipeline);
             Assert.Equal(3, runtime.OutputPipeline.Count);
             var errorResult = runtime.OutputPipeline[0] as AzureExceptionRecord;
@@ -173,7 +172,7 @@ public void LastParameterFindsLastError()
             var cmdlet = new ResolveError { CommandRuntime = mock };
             var message = "RuntimeErrorMessage";
             var exception = new Exception(message);
-            cmdlet.ExecuteCmdletWithExceptionInPipeline<AzureErrorRecord>("Resolve-AzureRmError", exception, new KeyValuePair<string, object>("Last", null ) );
+            cmdlet.ExecuteCmdletWithExceptionInPipeline<AzureErrorRecord>("Resolve-AzureRmError", exception, new KeyValuePair<string, object>("Last", null));
             Assert.NotNull(mock.ErrorStream);
             Assert.Single(mock.ErrorStream);
             Assert.NotNull(mock.OutputPipeline);
@@ -183,8 +182,6 @@ public void LastParameterFindsLastError()
             Assert.NotNull(record.Exception);
             Assert.Equal(typeof(Exception), record.Exception.GetType());
             Assert.Equal(message, record.Message);
-
-
         }
     }
 }

src/Accounts/Accounts.Test/ErrorResolutionTests.cs

@@ -58,35 +58,5 @@ public void SendFeedbackFailsInNonInteractive()
                 cmdlet.InvokeBeginProcessing();
             });
         }
-
-        [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void CanSerializeSimpleFeedbackPayloadIntoProperForm()
-        {
-            var payload = new PSAzureFeedback
-            {
-                ModuleName = "Module",
-                ModuleVersion = "1.0.0",
-                SubscriptionId = Guid.NewGuid().ToString(),
-                TenantId = Guid.NewGuid().ToString(),
-                Environment = "AzureCloud",
-                Recommendation = 10,
-                PositiveComments = "Positive",
-                NegativeComments = "Negative",
-                Email = "[email protected]"
-            };
-
-            var serializedPayload = MetricHelper.SerializeCustomEventPayload(payload);
-
-            Assert.Equal(payload.ModuleName, serializedPayload["moduleName"]);
-            Assert.Equal(payload.ModuleVersion, serializedPayload["moduleVersion"]);
-            Assert.Equal(payload.SubscriptionId.ToString(), serializedPayload["subscriptionId"]);
-            Assert.Equal(payload.TenantId.ToString(), serializedPayload["tenantId"]);
-            Assert.Equal(payload.Environment, serializedPayload["environment"]);
-            Assert.Equal(payload.Recommendation.ToString(), serializedPayload["recommendation"]);
-            Assert.Equal(payload.PositiveComments, serializedPayload["positiveComments"]);
-            Assert.Equal(payload.NegativeComments, serializedPayload["negativeComments"]);
-            Assert.Equal(payload.Email, serializedPayload["email"]);
-        }
     }
 }