Merge branch 'master' of github.com:/azure/azure-powershell into qq-fix-plus

Author: markcowl

.github/ISSUE_TEMPLATE/az-preview-bug-report.md

@@ -0,0 +1,67 @@
+---
+name:  Az 4.x preview bug report 
+about: Report errors or unexpected behaviors specifically for the Az 4.0  module in preview
+title: ''
+labels: 'Az 4.x Preview', 'Azure PS Team'
+assignees: ''
+
+---
+
+<!--
+
+- This issue is specifically for reporting issues related to the preview versions of the Az 4.0 PowerShell module
+- Please search the existing issues to see if there has been a similar issue filed
+- For issue related to importing a module, please refer to our troubleshooting guide:
+    - https://github.com/Azure/azure-powershell/blob/master/documentation/troubleshoot-module-load.md
+
+-->
+
+## Description
+
+
+
+## Steps to reproduce
+
+```powershell
+
+```
+
+## Environment data
+
+<!-- Please run $PSVersionTable and paste the output in the below code block -->
+
+```
+
+```
+
+## Module version
+
+<!-- Please run (Get-Module  -ListAvailable) and paste the output in the below code block -->
+
+```powershell
+
+```
+
+## Azure Profile
+
+<!-- Please indicate the selected Azure profile, if any -->
+
+```powershell
+
+```
+
+## Debug output
+
+<!-- Set $DebugPreference='Continue' before running the repro and paste the resulting debug stream in the below code block -->
+
+```
+
+```
+
+## Error output
+
+<!-- Please run Resolve-AzError and paste the output in the below code block -->
+
+```
+
+```

ChangeLog.md

@@ -1,3 +1,132 @@
+## 2.7.0 - September 2019
+#### Az.ApiManagement
+* Update '-Format' parameter description in 'Set-AzApiManagementPolicy' reference documentation
+* Removed references of deprecated cmdlet 'Update-AzApiManagementDeployment' from reference documentation. Use 'Set-AzApiManagement' instead.
+
+#### Az.Automation
+* Fixed example typo in reference documentation for 'Register-AzAutomationDscNode'
+* Added clarification on OS restriction to Register-AzAutomationDSCNode
+* Fixed Start-AzAutomationRunbook cmdlet Null reference exception for -Wait option.
+
+#### Az.Compute
+* Add UploadSizeInBytes parameter tp New-AzDiskConfig
+* Add Incremental parameter to New-AzSnapshotConfig
+* Add a low priority virtual machine feature:
+    - MaxPrice, EvictionPolicy and Priority parameters are added to New-AzVMConfig.
+    - MaxPrice parameter is added to New-AzVmssConfig, Update-AzVM and Update-AzVmss cmdlets.
+* Fix VM reference issue for Get-AzAvailabilitySet cmdlet when it lists all availability sets in the subscription.
+* Fix the null exception for Get-AzRemoteDesktopFile.
+* Fix VHD Seek method for end-relative position.
+* Fix UltraSSD issue for New-AzVM and Update-AzVM.
+
+#### Az.DataFactory
+* Adding 3 new commands for ADF V2 - Add-AzDataFactoryV2TriggerSubscription, Remove-AzDataFactoryV2TriggerSubscription, and Get-AzDataFactoryV2TriggerSubscriptionStatus
+* Updated ADF .Net SDK version to 4.1.3
+
+#### Az.HDInsight
+* Call out breaking changes
+
+#### Az.IotHub
+* Add support to invoke failover for an IotHub to the geo-paired disaster recovery region.
+* Add support to manage message enrichment for an IotHub. New cmdlets are:
+	- Add-AzIotHubMessageEnrichment
+	- Get-AzIotHubMessageEnrichment
+	- Remove-AzIotHubMessageEnrichment
+	- Set-AzIotHubMessageEnrichment
+
+#### Az.Monitor
+* Pointing to the most recent Monitor SDK, i.e. 0.24.1-preview
+   - Adds non-braking changes to the Metrics cmdlets, i.e. the Unit enumeration supports several new values. These are read-only cmdlets, so there would be no change in the input of the cmdlets.
+   - The api-version of the **ActionGroups** requests is now **2019-06-01**, before it was **2018-03-01**. The scenario tests have been updated to accommodate for this change.
+   - The constructors for the classes **EmailReceiver** and **WebhookReceiver** added one new mandatory argument, i.e. a Boolean value called **useCommonAlertSchema**. Currently, the value is fixed to **false** to hide this breaking change from the cmdlets. **NOTE**: this is a temporary change that must be validated by the Alerts team.
+   - The order of the arguments for the constructor of the class **Source** (related to the **ScheduledQueryRuleSource** class) changed from the previous SDK. This change required two unit tests to the be fixed: they compiled, but failed to pass the tests.
+   - The order of the arguments for the constructor of the class **AlertingAction** (related to the **ScheduledQueryRuleSource** class) changed from the previous SDK. This change required two unit tests to the be fixed: they compiled, but failed to pass the tests.
+* Support Dynamic Threshold criteria for metric alert V2
+	- New-AzMetricAlertRuleV2Criteria: now creats dynamic threshold criteria also
+	- Add-AzMetricAlertRuleV2: now accept dynamic threshold criteria also
+* Improvements in Scheduled Query Rule cmdlets (SQR)
+ - Cmdlets will accept 'Location' paramater in both formats, either the location (e.g. eastus) or the location display name (e.g. East US)
+ - Illustrated 'Enabled' parameter in help files properly
+ - Added examples for 'ActionGroup' optional parameter
+ - Overall improved help files
+* Fix bug in determining scope type for 'Set-AzActionRule'
+
+#### Az.Network
+* Fix incorrect example in 'New-AzApplicationGateway' reference documentation 
+* Add note in 'Get-AzNetworkWatcherPacketCapture' reference documentation about retrieving all properties for a packet capture
+* Fixed example in 'Test-AzNetworkWatcherIPFlow' reference documentation to correctly enumerate NICs
+* Improved cloud exception parsing to display additional details if they are present
+* Improved cloud exception parsing to handle additional type of SDK exception
+* Fixed incorrect mapping of Security Rule models
+* Added properties to network interface for private ip feature
+    - Added property 'PrivateEndpoint' as type of PSResourceId to PSNetworkInterface
+    - Added property 'PrivateLinkConnectionProperties' as type of PSIpConfigurationConnectivityInformation to PSNetworkInterfaceIPConfiguration
+    - Added new model class PSIpConfigurationConnectivityInformation
+* Added new ApplicationRuleProtocolType 'mssql' for Azure Firewall resource
+* MultiLink support in Virtual WAN
+    - New cmdlets
+        - New-AzVpnSiteLink
+        - New-AzVpnSiteLinkConnection
+    - Updated cmdlet:
+        - New-VpnSite
+        - Update-VpnSite
+        - New-VpnConnection
+        - Update-VpnConnection
+* Fixed documents for some PowerShell examples to use Az cmdlets instead of AzureRM cmdlets
+
+#### Az.RecoveryServices
+* Update AzureVMpolicy Object with ProtectedItemsCount Attribute
+* Added Tests for VM policy and Original Storage Account Restore
+
+#### Az.Resources
+* Fix bug where New-AzRoleAssignment could not be called without parameter Scope.
+
+#### Az.ServiceFabric
+* Fixed typo in example for 'Update-AzServiceFabricReliability' reference documentation
+* Adding new cmdlets to manage appliaction and services:
+    - New-AzServiceFabricApplication
+    - New-AzServiceFabricApplicationType
+    - New-AzServiceFabricApplicationTypeVersion
+    - New-AzServiceFabricService
+    - Update-AzServiceFabricApplication
+    - Get-AzServiceFabricApplication
+    - Get-AzServiceFabricApplicationType
+    - Get-AzServiceFabricApplicationTypeVersion
+    - Get-AzServiceFabricService
+    - Remove-AzServiceFabricApplication
+    - Remove-AzServiceFabricApplicationType
+    - Remove-AzServiceFabricApplicationTypeVersion
+    - Remove-AzServiceFabricServic
+* Upgraded Service Fabric SDK to version 1.2.0 which uses service fabric resource provider api-version 2019-03-01.
+
+#### Az.SignalR
+* Add Update, Restart, CheckNameAvailability, GetUsage Cmdlets
+
+#### Az.Sql
+* Update example in reference documentation for 'Get-AzSqlElasticPool'
+* Added vCore example to creating an elastic pool (New-AzSqlElasticPool).
+* Remove the validation of EmailAddresses and the check that EmailAdmins is not false in case EmailAddresses is empty in Set-AzSqlServerAdvancedThreatProtectionPolicy and Set-AzSqlDatabaseAdvancedThreatProtectionPolicy
+* Enabled removal of server/database auditing settings when multiple diagnostic settings that enable audit category exist.
+* Fix email addresses validation in multiple Sql Vulnerability Assessment cmdlets (Update-AzSqlDatabaseVulnerabilityAssessmentSetting, Update-AzSqlServerVulnerabilityAssessmentSetting, Update-AzSqlInstanceDatabaseVulnerabilityAssessmentSetting and Update-AzSqlInstanceVulnerabilityAssessmentSetting).
+
+#### Az.Storage
+* Updated example in reference documentation for 'Get-AzStorageAccountKey'
+* In upload/Downalod Azure File,support perserve the source File SMB properties (File Attributtes, File Creation Time, File Last Write Time) in the destination file
+    -  Set-AzStorageFileContent
+    -  Get-AzStorageFileContent
+* Fix Upload block blob with properties/metadate fail on container enabled ImmutabilityPolicy.
+    -  Set-AzStorageBlobContent
+* Support manage Azure File shares with Management plane API
+    -  New-AzRmStorageShare
+    -  Get-AzRmStorageShare
+    -  Update-AzRmStorageShare
+    -  Remove-AzRmStorageShare
+
+#### Az.Websites
+* Fixing issue where webapp Tags were getting deleted when migrating App to new ASPwhere webapp Tags were getting deleted when migrating App to new ASP
+* Fixing the Publish-AzureWebapp to work across Linux and windows
+* Update example in 'Get-AzWebAppPublishingProfile' reference documentation
+
 ## 2.6.0 - August 2019
 #### General
 * Fixed miscellaneous typos across numerous modules

src/ApiManagement/ApiManagement/Az.ApiManagement.psd1

@@ -3,7 +3,7 @@
 #
 # Generated by: Microsoft Corporation
 #
-# Generated on: 8/22/2019
+# Generated on: 9/19/2019
 #
 
 @{
@@ -12,7 +12,7 @@
 # RootModule = ''
 
 # Version number of this module.
-ModuleVersion = '1.3.0'
+ModuleVersion = '1.3.1'
 
 # Supported PSEditions
 CompatiblePSEditions = 'Core', 'Desktop'
@@ -189,14 +189,8 @@ PrivateData = @{
         # IconUri = ''
 
         # ReleaseNotes of this module
-        ReleaseNotes = '* Fixed miscellaneous typos across module
-* Fix for issue https://github.com/Azure/azure-powershell/issues/9351
-	- Update .net nuget version, which does not enforce restrictions on productId, apiId, groupId and userId
-* **Get-AzApiManagementProduct** - Added support for querying products using Api. 
-  https://github.com/Azure/azure-powershell/issues/9482
-* **New-AzApiManagementApiRevision** - Fix for issue where ApiRevisionDescription was not being set when creating new api revision
-https://github.com/Azure/azure-powershell/issues/9752
-* Fixed typo in model ''PsApiManagementOAuth2AuthrozationServer'' to ''PsApiManagementOAuth2AuthorizationServer'''
+        ReleaseNotes = '* Update ''-Format'' parameter description in ''Set-AzApiManagementPolicy'' reference documentation
+* Removed references of deprecated cmdlet ''Update-AzApiManagementDeployment'' from reference documentation. Use ''Set-AzApiManagement'' instead.'
 
         # Prerelease string of this module
         # Prerelease = ''

src/ApiManagement/ApiManagement/ChangeLog.md

@@ -18,6 +18,8 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+
+## Version 1.3.1
 * Update `-Format` parameter description in `Set-AzApiManagementPolicy` reference documentation
 * Removed references of deprecated cmdlet `Update-AzApiManagementDeployment` from reference documentation. Use `Set-AzApiManagement` instead.
 

src/ApiManagement/ApiManagement/Properties/AssemblyInfo.cs

@@ -41,5 +41,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 
-[assembly: AssemblyVersion("1.3.0")]
-[assembly: AssemblyFileVersion("1.3.0")]
+[assembly: AssemblyVersion("1.3.1")]
+[assembly: AssemblyFileVersion("1.3.1")]

src/Automation/Automation/Az.Automation.psd1

@@ -3,7 +3,7 @@
 #
 # Generated by: Microsoft Corporation
 #
-# Generated on: 8/22/2019
+# Generated on: 9/19/2019
 #
 
 @{
@@ -12,7 +12,7 @@
 # RootModule = ''
 
 # Version number of this module.
-ModuleVersion = '1.3.2'
+ModuleVersion = '1.3.3'
 
 # Supported PSEditions
 CompatiblePSEditions = 'Core', 'Desktop'
@@ -168,7 +168,9 @@ PrivateData = @{
         # IconUri = ''
 
         # ReleaseNotes of this module
-        ReleaseNotes = '* Fixed miscellaneous typos across module'
+        ReleaseNotes = '* Fixed example typo in reference documentation for ''Register-AzAutomationDscNode''
+* Added clarification on OS restriction to Register-AzAutomationDSCNode
+* Fixed Start-AzAutomationRunbook cmdlet Null reference exception for -Wait option.'
 
         # Prerelease string of this module
         # Prerelease = ''

src/Automation/Automation/ChangeLog.md

@@ -18,6 +18,8 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+
+## Version 1.3.3
 * Fixed example typo in reference documentation for `Register-AzAutomationDscNode`
 * Added clarification on OS restriction to Register-AzAutomationDSCNode
 * Fixed Start-AzAutomationRunbook cmdlet Null reference exception for -Wait option.

src/Automation/Automation/Properties/AssemblyInfo.cs

@@ -43,8 +43,8 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 
-[assembly: AssemblyVersion("1.3.2")]
-[assembly: AssemblyFileVersion("1.3.2")]
+[assembly: AssemblyVersion("1.3.3")]
+[assembly: AssemblyFileVersion("1.3.3")]
 #if !SIGN
 [assembly: InternalsVisibleTo("Microsoft.Azure.PowerShell.Cmdlets.Automation.Test")]
 #endif

src/Batch/Batch/BatchAccounts/GetBatchAccountNodeAgentSkuCommand.cs

@@ -14,11 +14,13 @@
 
 using Microsoft.Azure.Batch;
 using Microsoft.Azure.Commands.Batch.Models;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System.Management.Automation;
 using Constants = Microsoft.Azure.Commands.Batch.Utils.Constants;
 
 namespace Microsoft.Azure.Commands.Batch
 {
+    [CmdletDeprecation(ReplacementCmdletName = "Get-AzBatchSupportedImage")]
     [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzurePrefix + "BatchNodeAgentSku"),OutputType(typeof(PSNodeAgentSku))]
     public class GetBatchAccountNodeAgentSkuCommand : BatchObjectModelCmdletBase
     {

src/Batch/Batch/ChangeLog.md

@@ -19,6 +19,7 @@
 -->
 
 ## Upcoming Release
+* **Get-AzBatchNodeAgentSku** is deprecated and will be replaced by **Get-AzBatchSupportImage** in version 2.0.0.
 
 ## Version 1.1.1
 * Fixed typo in help message and documentation to capitalize Windows

src/Compute/Compute.Test/Compute.Test.csproj

@@ -12,7 +12,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Azure.Graph.RBAC" Version="3.4.0-preview" />
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="29.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="29.1.0" />
     <PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="2.4.2" />
     <PackageReference Include="Microsoft.Azure.Management.Network" Version="19.15.0-preview" />
   </ItemGroup>

src/Compute/Compute.Test/ScenarioTests/AvailabilitySetTests.cs

@@ -30,5 +30,12 @@ public void TestAvailabilitySet()
         {
             TestRunner.RunTestScript("Test-AvailabilitySet");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestAvailabilitySetVM()
+        {
+            TestRunner.RunTestScript("Test-AvailabilitySetVM");
+        }
     }
 }