Skip to content

Commit bc94344

Browse files
anusapanmsJinLei
andauthored
{IotHub} Fix sas-token decoding issue (Azure#13601)
* fix sas-token issue * Update ChangeLog.md Polish changelog Co-authored-by: Jin Lei <[email protected]>
1 parent 41897b2 commit bc94344

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

src/IotHub/IotHub.sln

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
21
Microsoft Visual Studio Solution File, Format Version 12.00
3-
# Visual Studio 15
4-
VisualStudioVersion = 15.0.27703.2042
2+
# Visual Studio Version 16
3+
VisualStudioVersion = 16.0.30427.197
54
MinimumVisualStudioVersion = 10.0.40219.1
65
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "IotHub", "IotHub\IotHub.csproj", "{78770A60-B18A-4442-A982-0CEE0356F8DB}"
76
EndProject
@@ -41,6 +40,10 @@ Global
4140
{142D7B0B-388A-4CEB-A228-7F6D423C5C2E}.Debug|Any CPU.Build.0 = Debug|Any CPU
4241
{142D7B0B-388A-4CEB-A228-7F6D423C5C2E}.Release|Any CPU.ActiveCfg = Release|Any CPU
4342
{142D7B0B-388A-4CEB-A228-7F6D423C5C2E}.Release|Any CPU.Build.0 = Release|Any CPU
43+
{6BD6B80A-06AF-4B5B-9230-69CCFC6C8D64}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
44+
{6BD6B80A-06AF-4B5B-9230-69CCFC6C8D64}.Debug|Any CPU.Build.0 = Debug|Any CPU
45+
{6BD6B80A-06AF-4B5B-9230-69CCFC6C8D64}.Release|Any CPU.ActiveCfg = Release|Any CPU
46+
{6BD6B80A-06AF-4B5B-9230-69CCFC6C8D64}.Release|Any CPU.Build.0 = Release|Any CPU
4447
{1E60D2AC-DEA7-403C-86DC-7B8C47F54668}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
4548
{1E60D2AC-DEA7-403C-86DC-7B8C47F54668}.Debug|Any CPU.Build.0 = Debug|Any CPU
4649
{1E60D2AC-DEA7-403C-86DC-7B8C47F54668}.Release|Any CPU.ActiveCfg = Release|Any CPU

src/IotHub/IotHub/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Fixed an issue of SAS token.
2122

2223
## Version 2.7.0
2324
* Allowed tags in IoT Hub create cmdlet.

src/IotHub/IotHub/IotHub/DataPlane/NewAzIotHubSasToken.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,10 @@ namespace Microsoft.Azure.Commands.Management.IotHub
1818
using System.Collections.Generic;
1919
using System.Globalization;
2020
using System.Management.Automation;
21+
using System.Net;
2122
using System.Security.Cryptography;
2223
using System.Text;
23-
using System.Web;
24+
using System.Text.RegularExpressions;
2425
using Microsoft.Azure.Commands.Management.IotHub.Common;
2526
using Microsoft.Azure.Commands.Management.IotHub.Models;
2627
using Microsoft.Azure.Devices;
@@ -179,15 +180,16 @@ private string createToken(string resourceUri, string keyName, string key, int d
179180
{
180181
TimeSpan sinceEpoch = DateTime.UtcNow - new DateTime(1970, 1, 1);
181182
var expiry = Convert.ToString((int)sinceEpoch.TotalSeconds + duration);
182-
string stringToSign = HttpUtility.UrlEncode(resourceUri) + "\n" + expiry;
183-
HMACSHA256 hmac = new HMACSHA256(Encoding.UTF8.GetBytes(key));
183+
string stringToSign = WebUtility.UrlEncode(resourceUri) + "\n" + expiry;
184+
stringToSign=Regex.Replace(stringToSign, "(%[0-9A-F]{2})", c => c.Value.ToLowerInvariant());
185+
HMACSHA256 hmac = new HMACSHA256(Convert.FromBase64String(key));
184186
var signature = Convert.ToBase64String(hmac.ComputeHash(Encoding.UTF8.GetBytes(stringToSign)));
185-
var sasToken = String.Format(CultureInfo.InvariantCulture, "SharedAccessSignature sr={0}&sig={1}&se={2}", HttpUtility.UrlEncode(resourceUri), HttpUtility.UrlEncode(signature), expiry);
187+
var sasToken = String.Format(CultureInfo.InvariantCulture, "SharedAccessSignature sr={0}&sig={1}&se={2}", WebUtility.UrlEncode(resourceUri), WebUtility.UrlEncode(signature), expiry);
186188
if (!string.IsNullOrEmpty(keyName))
187189
{
188190
sasToken += String.Format(CultureInfo.InvariantCulture, "&skn={0}", keyName);
189191
}
190-
return sasToken;
192+
return Regex.Replace(sasToken, "(%[0-9A-F]{2})", c => c.Value.ToLowerInvariant());
191193
}
192194
}
193195
}

0 commit comments

Comments
 (0)