Skip to content

Commit c70d4c4

Browse files
committed
Update PR comments
1 parent 146f190 commit c70d4c4

File tree

2 files changed

+5
-19
lines changed

2 files changed

+5
-19
lines changed

src/Network/Network.Test/ScenarioTests/NatGatewayTests.ps1

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,6 @@ function Test-NatGatewayCRUDMinimalParameters
7575
$listNatGateway = Get-AzNatGateway -ResourceGroupName "*";
7676
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
7777

78-
# Get all NatGateways in subscription wildcard for name
79-
$listNatGateway = Get-AzNatGateway -Name "*";
80-
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
81-
8278
# Get all NatGateways in subscription wildcard for both resource group and name
8379
$listNatGateway = Get-AzNatGateway -ResourceGroupName "*" -Name "*";
8480
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
@@ -142,10 +138,6 @@ function Test-NatGatewayWithSubnet
142138
$listNatGateway = Get-AzNatGateway -ResourceGroupName "*";
143139
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
144140

145-
# Get all NatGateways in subscription wildcard for name
146-
$listNatGateway = Get-AzNatGateway -Name "*";
147-
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
148-
149141
# Get all NatGateways in subscription wildcard for both resource group and name
150142
$listNatGateway = Get-AzNatGateway -ResourceGroupName "*" -Name "*";
151143
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
@@ -158,10 +150,11 @@ function Test-NatGatewayWithSubnet
158150
# Get Subnet
159151
$subnet2 = Get-AzvirtualNetwork -Name $vnetName -ResourceGroupName $rgname | Get-AzVirtualNetworkSubnetConfig -Name $subnetName;
160152

161-
Assert-AreEqual $vNatGateway @($subnet2.NatGateway.Name)
153+
Assert-AreEqual $vNatGateway.Id @($subnet2.NatGateway.Id)
162154

163155
# Remove Subnet
164-
Remove-AzVirtualNetworkSubnetConfig -Name $subnetName -VirtualNetwork $virtualNetwork
156+
Remove-AzVirtualNetworkSubnetConfig -Name $subnetName -VirtualNetwork $vnet
157+
Set-AzVirtualNetwork -VirtualNetwork $vnet
165158

166159
# Remove NatGateway
167160
$job = Remove-AzNatGateway -ResourceGroupName $rgname -Name $rname -PassThru -Force -AsJob;
@@ -229,10 +222,6 @@ function Test-NatGatewayCRUDAllParameters
229222
$listNatGateway = Get-AzNatGateway -ResourceGroupName "*";
230223
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
231224

232-
# Get all NatGateways in subscription wildcard for name
233-
$listNatGateway = Get-AzNatGateway -Name "*";
234-
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
235-
236225
# Get all NatGateways in subscription wildcard for both resource group and name
237226
$listNatGateway = Get-AzNatGateway -ResourceGroupName "*" -Name "*";
238227
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
@@ -267,10 +256,6 @@ function Test-NatGatewayCRUDAllParameters
267256
$listNatGateway = Get-AzNatGateway -ResourceGroupName "*";
268257
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
269258

270-
# Get all NatGateways in subscription wildcard for name
271-
$listNatGateway = Get-AzNatGateway -Name "*";
272-
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });
273-
274259
# Get all NatGateways in subscription wildcard for both resource group and name
275260
$listNatGateway = Get-AzNatGateway -ResourceGroupName "*" -Name "*";
276261
Assert-NotNull ($listNatGateway | Where-Object { $_.ResourceGroupName -eq $rgname -and $_.Name -eq $rname });

src/Network/Network/NatGateway/SetAzureRMNatGatewayCommand.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,9 @@ public class SetAzureNatGatewayCommand : NetworkBaseCmdlet
6666
public string NatGatewayId { get; set; }
6767

6868
[Parameter(
69-
Mandatory = false,
69+
Mandatory = true,
7070
ValueFromPipeline = true,
71+
ParameterSetName = SetByInputObjectParameterSet,
7172
HelpMessage = "The nat gateway")]
7273
public PSNatGateway NatGateway { get; set; }
7374

0 commit comments

Comments
 (0)