Address review feedback

cormacpayne · cormacpayne · commit cd939736393b · 2019-05-24T10:52:39.000-07:00
diff --git a/tools/CreateFilterMappings.ps1 b/tools/CreateFilterMappings.ps1
@@ -93,7 +93,7 @@ function Create-ProjectToFullPathMappings
     $Mappings = [ordered]@{}
     foreach ($ServiceFolder in $Script:ServiceFolders)
     {
-        $CsprojFiles = Get-ChildItem -Path $ServiceFolder -Filter "*.csproj" -Recurse | where { $_.FullName -notlike "*Stack*" }
+        $CsprojFiles = Get-ChildItem -Path $ServiceFolder -Filter "*.csproj" -Recurse
         foreach ($CsprojFile in $CsprojFiles)
         {
             $Mappings[$CsprojFile.BaseName] = $CsprojFile.FullName
@@ -124,7 +124,7 @@ function Create-SolutionToProjectMappings
     $Mappings = [ordered]@{}
     foreach ($ServiceFolder in $Script:ServiceFolders)
     {
-        $SolutionFiles = Get-ChildItem -Path $ServiceFolder.FullName -Filter "*.sln" | Where-Object { $_.FullName -notlike "*Stack*" }
+        $SolutionFiles = Get-ChildItem -Path $ServiceFolder.FullName -Filter "*.sln"
         foreach ($SolutionFile in $SolutionFiles)
         {
             $Mappings = Add-ProjectDependencies -Mappings $Mappings -SolutionPath $SolutionFile.FullName
@@ -220,8 +220,7 @@ function Create-ModuleMappings
     foreach ($ServiceFolder in $Script:ServiceFolders)
     {
         $Key = "src/$($ServiceFolder.Name)"
-        $ModuleManifestFiles = Get-ChildItem -Path $ServiceFolder.FullName -Filter "*.psd1" -Recurse | Where-Object { $_.FullName -notlike "*Stack*" -and `
-                                                                                                                      $_.FullName -notlike "*.Test*" -and `
+        $ModuleManifestFiles = Get-ChildItem -Path $ServiceFolder.FullName -Filter "*.psd1" -Recurse | Where-Object { $_.FullName -notlike "*.Test*" -and `
                                                                                                                       $_.FullName -notlike "*Release*" -and `
                                                                                                                       $_.FullName -notlike "*Debug*" -and `
                                                                                                                       $_.Name -like "Az.*" }

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ function Create-ProjectToFullPathMappings`
`93`	`93`	`$Mappings = [ordered]@{}`
`94`	`94`	`foreach ($ServiceFolder in $Script:ServiceFolders)`
`95`	`95`	`{`
`96`		`- $CsprojFiles = Get-ChildItem -Path $ServiceFolder -Filter ".csproj" -Recurse \| where { $_.FullName -notlike "Stack*" }`
	`96`	`+ $CsprojFiles = Get-ChildItem -Path $ServiceFolder -Filter "*.csproj" -Recurse`
`97`	`97`	`foreach ($CsprojFile in $CsprojFiles)`
`98`	`98`	`{`
`99`	`99`	`$Mappings[$CsprojFile.BaseName] = $CsprojFile.FullName`
`@@ -124,7 +124,7 @@ function Create-SolutionToProjectMappings`
`124`	`124`	`$Mappings = [ordered]@{}`
`125`	`125`	`foreach ($ServiceFolder in $Script:ServiceFolders)`
`126`	`126`	`{`
`127`		`- $SolutionFiles = Get-ChildItem -Path $ServiceFolder.FullName -Filter ".sln" \| Where-Object { $_.FullName -notlike "Stack*" }`
	`127`	`+ $SolutionFiles = Get-ChildItem -Path $ServiceFolder.FullName -Filter "*.sln"`
`128`	`128`	`foreach ($SolutionFile in $SolutionFiles)`
`129`	`129`	`{`
`130`	`130`	`$Mappings = Add-ProjectDependencies -Mappings $Mappings -SolutionPath $SolutionFile.FullName`
`@@ -220,8 +220,7 @@ function Create-ModuleMappings`
`220`	`220`	`foreach ($ServiceFolder in $Script:ServiceFolders)`
`221`	`221`	`{`
`222`	`222`	`$Key = "src/$($ServiceFolder.Name)"`
`223`		- $ModuleManifestFiles = Get-ChildItem -Path $ServiceFolder.FullName -Filter ".psd1" -Recurse \| Where-Object { $_.FullName -notlike "Stack*" -and `
`224`		- $_.FullName -notlike ".Test" -and `
	`223`	+ $ModuleManifestFiles = Get-ChildItem -Path $ServiceFolder.FullName -Filter ".psd1" -Recurse \| Where-Object { $_.FullName -notlike ".Test*" -and `
`225`	`224`	$_.FullName -notlike "Release" -and `
`226`	`225`	$_.FullName -notlike "Debug" -and `
`227`	`226`	`$_.Name -like "Az.*" }`