deprecation warning for old cmds and add possible hubsku/wantype

Author: nagula-ritvika

src/Network/Network.Test/ScenarioTests/CortexTests.ps1

@@ -35,7 +35,7 @@ function Test-CortexCRUD
 	$vpnConnection2Name = Get-ResourceName
 	$vpnLink1ConnectionName = Get-ResourceName
 	$vpnLink2ConnectionName = Get-ResourceName
-	
+
 	$storeName = 'blob' + $rgName
 
 	try

src/Network/Network/Cortex/VirtualHub/NewAzureRmVirtualHubCommand.cs

@@ -96,6 +96,7 @@ public class NewAzureRmVirtualHubCommand : VirtualHubBaseCmdlet
         [Parameter(
             Mandatory = false,
             HelpMessage = "The sku of the Virtual Hub.")]
+        [PSArgumentCompleter("Basic", "Standard")]
         public string Sku { get; set; }
 
         [Parameter(

src/Network/Network/Cortex/VirtualHub/NewAzureRmVirtualHubRouteCommand.cs

@@ -19,7 +19,9 @@ namespace Microsoft.Azure.Commands.Network
     using Microsoft.Azure.Commands.Network.Models;
     using System.Linq;
     using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
+    using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
+    [CmdletDeprecation(ReplacementCmdletName = "Add-AzVirtualHubRoute")]
     [Cmdlet(
         VerbsCommon.New,
         ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualHubRoute",

src/Network/Network/Cortex/VirtualHub/NewAzureRmVirtualHubRouteTableCommand.cs

@@ -19,7 +19,9 @@ namespace Microsoft.Azure.Commands.Network
     using Microsoft.Azure.Commands.Network.Models;
     using System.Linq;
     using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
+    using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
+    [CmdletDeprecation(ReplacementCmdletName = "Add-AzVirtualHubRouteTable")]
     [Cmdlet(VerbsCommon.New,
         ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualHubRouteTable",
         SupportsShouldProcess = false),
@@ -35,6 +37,9 @@ public override void Execute()
         {
             base.Execute();
 
+            // Since this cmdlet and the VirtualHubRouteTable property of
+            // hub will be deprecated, we will rename this route table to 
+            // called defaultRouteTable and it will be attached to All_Branches
             var virtualHubRouteTable = new PSVirtualHubRouteTable { 
                 Routes = this.Route == null ? new List<PSVirtualHubRoute>() : this.Route?.ToList(),
                 Name = "defaultRouteTable",

src/Network/Network/Cortex/VirtualHub/UpdateAzureRmVirtualHubCommand.cs

@@ -95,6 +95,7 @@ public class UpdateAzureRmVirtualHubCommand : VirtualHubBaseCmdlet
         [Parameter(
             Mandatory = false,
             HelpMessage = "The sku of the Virtual Hub.")]
+        [PSArgumentCompleter("Basic", "Standard")]
         public string Sku { get; set; }
 
         [Parameter(

src/Network/Network/Cortex/VirtualWan/NewAzureRmVirtualWanCommand.cs

@@ -72,6 +72,7 @@ public class NewAzureRmVirtualWanCommand : VirtualWanBaseCmdlet
         [Parameter(
             Mandatory = false,
             HelpMessage = "The type of the Virtual Wan.")]
+        [PSArgumentCompleter("Basic", "Standard")]
         public string VirtualWANType { get; set; }
 
         [Parameter(

src/Network/Network/Cortex/VirtualWan/UpdateAzureRmVirtualWanCommand.cs

@@ -89,7 +89,9 @@ public class UpdateAzureRmVirtualWanCommand : VirtualWanBaseCmdlet
         [Parameter(
             Mandatory = false,
             HelpMessage = "The type of the Virtual Wan.")]
-        public string VirtualWANType { get; set; }
+        [PSArgumentCompleter("Basic", "Standard")]
+        public string VirtualWANType
+        { get; set; }
 
         [Parameter(
             Mandatory = false,