[Storage] change default action to make it align with swagger (Azure#11641)

blueww · web-flow · commit da9fecff0ce8 · 2020-04-21T17:25:50.000+08:00
diff --git a/src/Storage/Storage.Management/ChangeLog.md b/src/Storage/Storage.Management/ChangeLog.md
@@ -18,7 +18,10 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
-* Skip duplicated rules when add NetworkRules, to avoid server failure
+* Fixed #9880: Change NetWorkRule DefaultAction value defination to align with swagger.
+	- Update-AzStorageAccountNetworkRuleSet
+	- Get-AzStorageAccountNetworkRuleSet
+* Fixed #11624: Skip duplicated rules when add NetworkRules, to avoid server failure
     - `Add-AzStorageAccountNetworkRule`
 
 ## Version 1.14.0
diff --git a/src/Storage/Storage.Management/Models/PSNetworkRule.cs b/src/Storage/Storage.Management/Models/PSNetworkRule.cs
@@ -32,8 +32,8 @@ public enum PSNetWorkRuleBypassEnum
     //Wrapper of NetworkRuleSet property DefaultAction 
     public enum PSNetWorkRuleDefaultActionEnum
     {
-        Deny = 0,
-        Allow = 1
+        Allow = 0,
+        Deny = 1
     }
 
     //Wrapper of NetworkRule property Action 
diff --git a/src/Storage/Storage.Management/StorageAccount/UpdateAzureStorageAccountNetworkRuleSet.cs b/src/Storage/Storage.Management/StorageAccount/UpdateAzureStorageAccountNetworkRuleSet.cs
@@ -62,8 +62,6 @@ public PSNetWorkRuleBypassEnum Bypass
             }
         }
 
-        public const string ChangeDesc = "The DefaultAction value will change in a future release from: Allow = 1, Deny = 0, to: Allow = 0, Deny = 1.";
-        [CmdletParameterBreakingChange("DefaultAction", ChangeDescription = ChangeDesc)]
         [Parameter(
             Mandatory = false,
             HelpMessage = "Storage Account NetworkRule DefaultAction.")]

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,8 @@ public enum PSNetWorkRuleBypassEnum`
`32`	`32`	`//Wrapper of NetworkRuleSet property DefaultAction`
`33`	`33`	`public enum PSNetWorkRuleDefaultActionEnum`
`34`	`34`	`{`
`35`		`- Deny = 0,`
`36`		`- Allow = 1`
	`35`	`+ Allow = 0,`
	`36`	`+ Deny = 1`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`//Wrapper of NetworkRule property Action`
Original file line number	Diff line number	Diff line change
`@@ -62,8 +62,6 @@ public PSNetWorkRuleBypassEnum Bypass`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
`65`		`- public const string ChangeDesc = "The DefaultAction value will change in a future release from: Allow = 1, Deny = 0, to: Allow = 0, Deny = 1.";`
`66`		`- [CmdletParameterBreakingChange("DefaultAction", ChangeDescription = ChangeDesc)]`
`67`	`65`	`[Parameter(`
`68`	`66`	`Mandatory = false,`
`69`	`67`	`HelpMessage = "Storage Account NetworkRule DefaultAction.")]`