Skip to content

Fix SSLHandshakeException in Visual Recognition #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2018
Merged

Conversation

lpatino10
Copy link
Contributor

There was an SSLHandshakeException occurring in Visual Recognition when using Oracle JDK 7.

This PR makes a change to the core HTTP code to allow Visual Recognition to connect while preserving functionality for users using the IBM JDK.

@codecov-io
Copy link

codecov-io commented Mar 9, 2018

Codecov Report

Merging #890 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #890     +/-   ##
===========================================
+ Coverage     63.95%   64.16%   +0.2%     
- Complexity     2067     2071      +4     
===========================================
  Files           454      454             
  Lines         10618    10651     +33     
  Branches        631      631             
===========================================
+ Hits           6791     6834     +43     
+ Misses         3502     3494      -8     
+ Partials        325      323      -2
Impacted Files Coverage Δ Complexity Δ
...tson/developer_cloud/http/HttpClientSingleton.java 83.33% <100%> (+0.72%) 9 <0> (+1) ⬆️
...r_cloud/conversation/v1/model/WorkspaceExport.java 66.66% <0%> (-4.77%) 9% <0%> (-1%)
...xt/v1/websocket/SpeechToTextWebSocketListener.java 72.46% <0%> (-4.35%) 13% <0%> (-1%)
.../developer_cloud/text_to_speech/v1/model/Word.java 100% <0%> (ø) 7% <0%> (ø) ⬇️
..._cloud/speech_to_text/v1/model/RegisterStatus.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...oper_cloud/text_to_speech/v1/model/CustomWord.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...r_cloud/speech_to_text/v1/model/AudioResource.java 100% <0%> (ø) 5% <0%> (ø) ⬇️
...loud/conversation/v1/model/DialogNodeNextStep.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../developer_cloud/conversation/v1/Conversation.java 70.85% <0%> (+0.36%) 104% <0%> (+1%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db1404...33403f1. Read the comment docs.

@germanattanasio germanattanasio merged commit 10e575a into master Mar 9, 2018
@lpatino10 lpatino10 deleted the ssl-fix branch March 9, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants