Skip to content

Commit 3677b5d

Browse files
committed
feat(AssistantV2): Added null checks for required parameters
1 parent d1ce560 commit 3677b5d

File tree

1 file changed

+38
-6
lines changed

1 file changed

+38
-6
lines changed

Scripts/Services/Assistant/v2/Assistant.cs

Lines changed: 38 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,17 @@ public Assistant(Credentials credentials)
126126
public bool CreateSession(SuccessCallback<SessionResponse> successCallback, FailCallback failCallback, String assistantId, Dictionary<string, object> customData = null)
127127
{
128128
if (successCallback == null)
129-
throw new ArgumentNullException("successCallback");
129+
{
130+
throw new ArgumentNullException("successCallback is required for CreateSession");
131+
}
130132
if (failCallback == null)
131-
throw new ArgumentNullException("failCallback");
133+
{
134+
throw new ArgumentNullException("failCallback is required for CreateSession");
135+
}
136+
if(string.IsNullOrEmpty(assistantId))
137+
{
138+
throw new ArgumentException("assistantId is required for CreateSession");
139+
}
132140

133141
CreateSessionRequestObj req = new CreateSessionRequestObj();
134142
req.SuccessCallback = successCallback;
@@ -229,9 +237,21 @@ private void OnCreateSessionResponse(RESTConnector.Request req, RESTConnector.Re
229237
public bool DeleteSession(SuccessCallback<object> successCallback, FailCallback failCallback, String assistantId, String sessionId, Dictionary<string, object> customData = null)
230238
{
231239
if (successCallback == null)
232-
throw new ArgumentNullException("successCallback");
240+
{
241+
throw new ArgumentNullException("successCallback is required for DeleteSession");
242+
}
233243
if (failCallback == null)
234-
throw new ArgumentNullException("failCallback");
244+
{
245+
throw new ArgumentNullException("failCallback is required for DeleteSession");
246+
}
247+
if(string.IsNullOrEmpty(assistantId))
248+
{
249+
throw new ArgumentException("assistantId is required for DeleteSession");
250+
}
251+
if (string.IsNullOrEmpty(sessionId))
252+
{
253+
throw new ArgumentException("sessionId is required for DeleteSession");
254+
}
235255

236256
DeleteSessionRequestObj req = new DeleteSessionRequestObj();
237257
req.SuccessCallback = successCallback;
@@ -334,9 +354,21 @@ private void OnDeleteSessionResponse(RESTConnector.Request req, RESTConnector.Re
334354
public bool Message(SuccessCallback<MessageResponse> successCallback, FailCallback failCallback, String assistantId, String sessionId, MessageRequest request = null, Dictionary<string, object> customData = null)
335355
{
336356
if (successCallback == null)
337-
throw new ArgumentNullException("successCallback");
357+
{
358+
throw new ArgumentNullException("successCallback is required for Message");
359+
}
338360
if (failCallback == null)
339-
throw new ArgumentNullException("failCallback");
361+
{
362+
throw new ArgumentNullException("failCallback is required for Message");
363+
}
364+
if (string.IsNullOrEmpty(assistantId))
365+
{
366+
throw new ArgumentException("assistantId is required for Message");
367+
}
368+
if (string.IsNullOrEmpty(sessionId))
369+
{
370+
throw new ArgumentException("sessionId is required for Message");
371+
}
340372

341373
MessageRequestObj req = new MessageRequestObj();
342374
req.SuccessCallback = successCallback;

0 commit comments

Comments
 (0)