Merge pull request #530 from watson-developer-cloud/feature-v3-separate-core

Separate core from services

Author: mediumTaj

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "Core"]
+	path = Core
+	url = [email protected]:mediumTaj/IBM.Cloud.SDK.Unity.git

.travis.yml

@@ -9,7 +9,12 @@ rvm:
 cache:
   directories:
     - ./Unity
+git:
+  submodules: false
 before_install:
+# Use sed to replace the SSH URL with the public URL, then initialize submodules
+- sed -i -e 's/[email protected]:/https:\/\/github.com\//' .gitmodules
+- git submodule update --init --recursive
 - chmod a+x ./Travis/installUnity.sh
 - npm install -g [email protected]
 install:

Assistant/v2/Assistant.cs

@@ -94,7 +94,7 @@ public AssistantService(Credentials credentials)
             }
             else
             {
-                throw new WatsonException("Please provide a username and password or authorization token to use the Assistant service. For more information, see https://github.com/watson-developer-cloud/unity-sdk/#configuring-your-service-credentials");
+                throw new IBMException("Please provide a username and password or authorization token to use the Assistant service. For more information, see https://github.com/watson-developer-cloud/unity-sdk/#configuring-your-service-credentials");
             }
         }
 
@@ -155,7 +155,7 @@ public bool CreateSession(Callback<SessionResponse> callback, String assistantId
 
         private void OnCreateSessionResponse(RESTConnector.Request req, RESTConnector.Response resp)
         {
-            WatsonResponse<SessionResponse> response = new WatsonResponse<SessionResponse>
+            DetailedResponse<SessionResponse> response = new DetailedResponse<SessionResponse>
             {
                 Result = new SessionResponse()
             };
@@ -168,14 +168,14 @@ private void OnCreateSessionResponse(RESTConnector.Request req, RESTConnector.Re
                 fsResult r = fsJsonParser.Parse(Encoding.UTF8.GetString(resp.Data), out data);
                 if (!r.Succeeded)
                 {
-                    throw new WatsonException(r.FormattedMessages);
+                    throw new IBMException(r.FormattedMessages);
                 }
 
                 object obj = response.Result;
                 r = serializer.TryDeserialize(data, obj.GetType(), ref obj);
                 if (!r.Succeeded)
                 {
-                    throw new WatsonException(r.FormattedMessages);
+                    throw new IBMException(r.FormattedMessages);
                 }
 
                 customData.Add("json", data);
@@ -252,7 +252,7 @@ public bool DeleteSession(Callback<object> callback, String assistantId, String
 
         private void OnDeleteSessionResponse(RESTConnector.Request req, RESTConnector.Response resp)
         {
-            WatsonResponse<object> response = new WatsonResponse<object>
+            DetailedResponse<object> response = new DetailedResponse<object>
             {
                 Result = new object()
             };
@@ -265,14 +265,14 @@ private void OnDeleteSessionResponse(RESTConnector.Request req, RESTConnector.Re
                 fsResult r = fsJsonParser.Parse(Encoding.UTF8.GetString(resp.Data), out data);
                 if (!r.Succeeded)
                 {
-                    throw new WatsonException(r.FormattedMessages);
+                    throw new IBMException(r.FormattedMessages);
                 }
 
                 object obj = response.Result;
                 r = serializer.TryDeserialize(data, obj.GetType(), ref obj);
                 if (!r.Succeeded)
                 {
-                    throw new WatsonException(r.FormattedMessages);
+                    throw new IBMException(r.FormattedMessages);
                 }
 
                 customData.Add("json", data);
@@ -363,7 +363,7 @@ public bool Message(Callback<MessageResponse> callback, String assistantId, Stri
 
         private void OnMessageResponse(RESTConnector.Request req, RESTConnector.Response resp)
         {
-            WatsonResponse<MessageResponse> response = new WatsonResponse<MessageResponse>();
+            DetailedResponse<MessageResponse> response = new DetailedResponse<MessageResponse>();
             response.Result = new MessageResponse();
             fsData data = null;
             Dictionary<string, object> customData = ((RequestObject<MessageResponse>)req).CustomData;
@@ -378,14 +378,14 @@ private void OnMessageResponse(RESTConnector.Request req, RESTConnector.Response
                 fsResult r = fsJsonParser.Parse(Encoding.UTF8.GetString(resp.Data), out data);
                 if (!r.Succeeded)
                 {
-                    throw new WatsonException(r.FormattedMessages);
+                    throw new IBMException(r.FormattedMessages);
                 }
 
                 object obj = response.Result;
                 r = serializer.TryDeserialize(data, obj.GetType(), ref obj);
                 if (!r.Succeeded)
                 {
-                    throw new WatsonException(r.FormattedMessages);
+                    throw new IBMException(r.FormattedMessages);
                 }
 
                 customData.Add("json", data);

Common/Common.cs

@@ -23,8 +23,15 @@ namespace IBM.Watson
 {
     public class Common : MonoBehaviour
     {
+        /// <summary>
+        /// The SDK version.
+        /// </summary>
         public const string Version = "watson-apis-unity-sdk-2.12.0";
         /// <summary>
+        /// Tracking for onboarding.
+        /// </summary>
+        public const string TrackingQueryParam = "target=/developer/watson&cm_sp=WatsonPlatform-WatsonServices-_-OnPageNavLink-IBMWatson_SDKs-_-Unity";
+        /// <summary>
         /// Returns a set of default headers to use with each request.
         /// </summary>
         /// <param name="serviceName">The service name to be used in X-IBMCloud-SDK-Analytics header.</param>