Skip to content

Commit daef2e9

Browse files
committed
revise editorconfig for missing underscores, add missing language to readme code example, remove constant rule from contributing.md
1 parent da6793e commit daef2e9

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

.editorconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ root = true
33

44
; Unix-style newlines
55
[*]
6-
end of line = LF
6+
end_of_line = LF
77

88
; 2-column space indentation
99
[*.cs]

.github/CONTRIBUTING.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ or [Stack Overflow](http://stackoverflow.com/questions/ask?tags=ibm-watson).
1414
* No K&R coding style. Braces {} should be on their own line, aligned with the parent statement.
1515
* No public variables, always use public properties unless there is no other workaround.
1616
* Properties should be camel case, no underscores (e.g. public bool IsReady { get; set; }).
17-
* Constants should be all PascalCase (e.g. static readonly string ConfigFile = "/Config.json"). This includes enumerations.
1817
* All public functions and types of all classes should be fully documented using the XML comment style.
1918
* Local variables should be camel case. (e.g. var speechToText = new SpeechToText())
2019
* Use protected on variables & functions only if you plan to inherit from the class or there is a good chance we will need to be polymorphic.
@@ -34,7 +33,7 @@ If you want to contribute to the repository, follow these steps:
3433
1. Fork the repo.
3534
1. Develop and test your code changes Make sure you work in the `develop` branch. PLEASE don't do your work in `master`.
3635
1. Add a unit test for any new classes you add. Only refactoring and documentation changes require no new tests.
37-
1. Run the Watson->Run All UnitTest inside of Unity, make sure all tests work.
36+
1. Run the Watson->Run All UnitTest inside of Unity, make sure all tests work.
3837
1. Commit your changes.
3938
1. Push to your fork and submit a pull request.
4039

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ You use tokens to write applications that make authenticated requests to IBM Wat
103103

104104
You can write an authentication proxy in IBM® Bluemix® that obtains and returns a token to your client application, which can then use the token to call the service directly. This proxy eliminates the need to channel all service requests through an intermediate server-side application, which is otherwise necessary to avoid exposing your service credentials from your client application.
105105

106-
```
106+
```cs
107107
using IBM.Watson.DeveloperCloud.Services.Conversation.v1;
108108
using IBM.Watson.DeveloperCloud.Utilities;
109109

@@ -119,7 +119,7 @@ void Start()
119119

120120
There is a helper class included to obtain tokens from within your Unity application.
121121

122-
```
122+
```cs
123123
using IBM.Watson.DeveloperCloud.Utilities;
124124

125125
AuthenticationToken _authenticationToken;

0 commit comments

Comments
 (0)