-
Notifications
You must be signed in to change notification settings - Fork 207
Error handling #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Error handling #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction to get response code
@kimberlysiva Can you test this when you have a chance? |
…ect ifdef for restconnector security import, incorrect name in document conversion
@mediumTaj Thanks so much for this! The failure callbacks are great, I'm correctly catching the 409 errors for STT custom language models now. I've tested STT and Conversation on Mac, Windows, and Hololens. Everything is working great so far! |
…d/unity-sdk into 265-error-handling
germanattanasio
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactoring SDK to have a success and failure callbacks. We also now pass a dictionary for custom data.
We can now use generic handlers as callbacks for multiple response types. The raw json response is always passed as
json
in the customData dictionary.