Implement semantic release #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpopp07
reviewed
Aug 16, 2018
.travis.yml
Outdated
| @@ -7,6 +7,7 @@ cache: | |||
| - ./Unity | |||
| before_install: | |||
| - chmod a+x ./Travis/installUnity.sh | |||
| - npm install npm@latest -g | |||
There was a problem hiding this comment.
Was using npm@latest recommended in semantic-release documentation? To me, that seems inadvisable since that could introduce breaking changes if npm releases a new major version.
There was a problem hiding this comment.
Yeah I followed the guide here. Should I just leave this command out? or what should i replace it with
There was a problem hiding this comment.
It's really not a big deal but I would use npm install -g [email protected] to future-proof yourself
lpatino10
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds basic semantic release to the Unity SDK. We will not be able to automate release on the Unity Asset store since this needs to be done in the Unity editor.