Skip to content

chore(logging): Corrected the wrongly-labelled method name. #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Conversation

HjoshM
Copy link
Contributor

@HjoshM HjoshM commented Feb 12, 2019

Summary

Changed OnRecognize() to OnRecognizeSpeaker().

Other Information

Caused confusion when searching for debug log messages of recognizing different speakers.

Thanks for contributing to the Watson Developer Cloud!

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Joshua!

@mediumTaj mediumTaj changed the title Corrected the wrongly-labelled method name. chore(logging): Corrected the wrongly-labelled method name. Feb 12, 2019
@mediumTaj mediumTaj merged commit ef4eb28 into watson-developer-cloud:master Feb 12, 2019
@HjoshM HjoshM deleted the master branch February 12, 2019 12:54
@mediumTaj
Copy link
Contributor

🎉 This PR is included in version 2.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants