Common class for headers #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamoonraja
reviewed
Mar 6, 2019
| @@ -177,7 +177,11 @@ public bool Message(Callback<Dictionary<string, JObject>> callback, string works | |||
| } | |||
| } | |||
|
|
|||
| req.Headers["X-IBMCloud-SDK-Analytics"] = "service_name=conversation;service_version=V1;operation_id=Message"; | |||
| foreach(KeyValuePair<string, string> kvp in Common.GetDefaultheaders("conversation", "V1", "Message")) | |||
There was a problem hiding this comment.
Don't we need to do the same change for other services like LT for instance.
There was a problem hiding this comment.
Yes! This is merging to the V3 branch though. I only have Assistant here so far. The rest are taken care of once I fully regenerate.
mamoonraja
approved these changes
Mar 7, 2019
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a common class to get default headers.