Remove custom data #538
Merged
Remove custom data #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamoonraja
reviewed
Mar 20, 2019
| customData.Add(Constants.String.JSON, tm.Text); | ||
| if (tm.Headers != null && tm.Headers.Count > 0) | ||
| customData.Add(Constants.String.RESPONSE_HEADERS, tm.Headers); | ||
| //Dictionary<string, object> customData = new Dictionary<string, object>(); |
There was a problem hiding this comment.
Shouldn't we just remove this part instead of commenting it out.
There was a problem hiding this comment.
ok I removed the block
mamoonraja
approved these changes
Mar 20, 2019
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes dependency of a customData object. Custom request headers are no set directly on the service instance for the call. Response headers and response json are returned in the DetailedResponse object.