Feature remove submodule #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mamoonraja
approved these changes
Apr 1, 2019
| assistant = new Assistant(credentials); | ||
| assistant.VersionDate = "2019-03-28"; | ||
| assistant.ListWorkspaces(OnListWorkspaces); | ||
| assistant = new AssistantService( |
There was a problem hiding this comment.
Do we need AssistantService assistant in line 111 if we are defining it here too?
There was a problem hiding this comment.
Yes, 111 is where we declare the assistant variable and 129 is where we instantiate the service.
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request revises install instructions to download the core as a separate repo instead of a submodule. Additionally fixes were applied to examples and readme examples were corrected.