Skip to content

feat(regerate): regenerate services for pre-release #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2019

Conversation

mamoonraja
Copy link
Member

@mamoonraja mamoonraja commented Aug 29, 2019

This PR generates services to match new patterns introduces the SDK Core.

  • Regenerate services
  • Update Tests and Examples

@mamoonraja mamoonraja requested a review from mediumTaj August 29, 2019 16:44
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change mamoon, the service name seems to be getting lost in the error message in the constructor. Looks like this is happening in all services.

@mamoonraja mamoonraja force-pushed the feat/regenerate-pre-release-1 branch from ecfd0bd to 4d2a36f Compare August 29, 2019 18:20
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! a couple of readme changes but fine after that

@mediumTaj mediumTaj merged commit c20297f into 4.0.0-rc1 Aug 30, 2019
@mediumTaj
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants