Skip to content

feat(SetServiceUrl): provide setServiceUrl method and use serviceUrl #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2019
Merged

feat(SetServiceUrl): provide setServiceUrl method and use serviceUrl #591

merged 1 commit into from
Sep 17, 2019

Conversation

mamoonraja
Copy link
Member

  • Use serviceUrl instead of Url for service level URLs
  • Regenerate based on generator changes

@mamoonraja
feat(SetServiceUrl): provide setServiceUrl method and use serviceUrl …
a6df1b8 
…instead of Url

Use serviceUrl instead of Url for service level urls
@mamoonraja mamoonraja changed the title feat(SetServiceUrl): provide setServiceUrl method and use serviceUrl … feat(SetServiceUrl): provide setServiceUrl method and use serviceUrl Sep 16, 2019
mediumTaj
mediumTaj approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@mamoonraja mamoonraja merged commit 66fcbf0 into 4.0.0-rc1 Sep 17, 2019
@mediumTaj
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mediumTaj mediumTaj mediumTaj approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamoonraja @mediumTaj