Skip to content

Add unit tests for language translator #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2019

Conversation

mamoonraja
Copy link
Member

This PR adds unit tests for Language translator:

  • Add NSubstitute library
  • Move connector to base service and settable at service level, supporting work done here.
  • Add unit tests for Language translator and add code coverage for unit tests.

@mamoonraja mamoonraja requested a review from mediumTaj November 12, 2019 15:28
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think this looks good for unit tests. What kind of coverage are you getting?

@mamoonraja
Copy link
Member Author

mamoonraja commented Nov 13, 2019

@mediumTaj Currently it's around 30 since I still need to add few more tests. I will do that before we merge this one.

@mamoonraja
Copy link
Member Author

Adding more unit tests in PR for the next release.

@mamoonraja mamoonraja merged commit 3f1ebbe into master Nov 26, 2019
@mediumTaj
Copy link
Contributor

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants