fix: preserve require.resolve / dynamic require / dynamic import (#249)

Author: fi3ework

CONTRIBUTING.md

@@ -138,6 +138,6 @@ Here are the steps to publish (we generally use CI for releases and avoid publis
 
 The project is still in its early stages and under active development, so it possible dependents on Rsbuild or Rspack canary versions to test the latest features. The current versions are:
 
-| Package      | Link                                                                                    |
-| ------------ | --------------------------------------------------------------------------------------- |
-| @rspack/core | https://github.com/web-infra-dev/rspack/commit/bb0219fd3eaee45d9957b4c29a176f2ac67a84ee |
+| Package      | Link                                              |
+| ------------ | ------------------------------------------------- |
+| @rspack/core | https://github.com/web-infra-dev/rspack/pull/7939 |

package.json

@@ -63,7 +63,7 @@
   },
   "pnpm": {
     "overrides": {
-      "@rspack/core": "npm:@rspack/[email protected].6-canary-bb0219fd-20240920080859"
+      "@rspack/core": "npm:@rspack/[email protected].9-canary-0cad17d5-20240929151646"
     }
   }
 }

packages/core/src/config.ts

@@ -432,6 +432,14 @@ export async function createConstantRsbuildConfig(): Promise<RsbuildConfig> {
 }
 
 const composeFormatConfig = (format: Format): RsbuildConfig => {
+  const jsParserOptions = {
+    importMeta: false,
+    requireResolve: false,
+    requireDynamic: false,
+    requireAsExpression: false,
+    importDynamic: false,
+  };
+
   switch (format) {
     case 'esm':
       return {
@@ -446,13 +454,12 @@ const composeFormatConfig = (format: Format): RsbuildConfig => {
             },
             module: {
               parser: {
-                javascript: {
-                  importMeta: false,
-                },
+                javascript: jsParserOptions,
               },
             },
             optimization: {
               concatenateModules: true,
+              sideEffects: 'flag',
             },
             experiments: {
               outputModule: true,
@@ -467,9 +474,7 @@ const composeFormatConfig = (format: Format): RsbuildConfig => {
           rspack: {
             module: {
               parser: {
-                javascript: {
-                  importMeta: false,
-                },
+                javascript: jsParserOptions,
               },
             },
             output: {

packages/core/tests/__snapshots__/config.test.ts.snap

@@ -102,12 +102,17 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
             "module": {
               "parser": {
                 "javascript": {
+                  "importDynamic": false,
                   "importMeta": false,
+                  "requireAsExpression": false,
+                  "requireDynamic": false,
+                  "requireResolve": false,
                 },
               },
             },
             "optimization": {
               "concatenateModules": true,
+              "sideEffects": "flag",
             },
             "output": {
               "chunkFormat": "module",
@@ -252,7 +257,11 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
             "module": {
               "parser": {
                 "javascript": {
+                  "importDynamic": false,
                   "importMeta": false,
+                  "requireAsExpression": false,
+                  "requireDynamic": false,
+                  "requireResolve": false,
                 },
               },
             },