up

Author: fi3ework

examples/react-component-umd/rslib.config.ts

@@ -13,8 +13,6 @@ export default defineConfig({
         },
         distPath: {
           root: './dist/umd',
-          css: '.',
-          cssAsync: '.',
         },
       },
     },

packages/core/src/config.ts

@@ -33,6 +33,7 @@ import type {
   BannerAndFooter,
   Format,
   LibConfig,
+  LibOnlyConfig,
   PkgJson,
   Redirect,
   RsbuildConfigOutputTarget,
@@ -1112,19 +1113,20 @@ export async function composeCreateRsbuildConfig(
       config: mergeRsbuildConfig(
         constantRsbuildConfig,
         libRsbuildConfig,
-        omit(userConfig, [
-          'bundle',
-          'format',
-          'autoExtension',
-          'autoExternal',
-          'redirect',
-          'syntax',
-          'externalHelpers',
-          'banner',
-          'footer',
-          'dts',
-          'shims',
-        ]),
+        omit<LibConfig, keyof LibOnlyConfig>(userConfig, {
+          bundle: true,
+          format: true,
+          autoExtension: true,
+          autoExternal: true,
+          redirect: true,
+          syntax: true,
+          externalHelpers: true,
+          banner: true,
+          footer: true,
+          dts: true,
+          shims: true,
+          umdName: true,
+        }),
       ),
     };
   });

packages/core/src/types/config/index.ts

@@ -83,6 +83,8 @@ export interface LibConfig extends RsbuildConfig {
   umdName?: string;
 }
 
+export type LibOnlyConfig = Omit<LibConfig, keyof RsbuildConfig>;
+
 export interface RslibConfig extends RsbuildConfig {
   lib: LibConfig[];
 }

packages/core/src/utils/helper.ts

@@ -147,16 +147,17 @@ export function pick<T, U extends keyof T>(
 
 export function omit<T extends object, U extends keyof T>(
   obj: T,
-  keys: ReadonlyArray<U>,
-): Omit<T, U> {
+  keysObj: Record<U, boolean>,
+): Omit<T, keyof U> {
+  type K = keyof U;
   return Object.keys(obj).reduce(
     (ret, key) => {
-      if (!keys.includes(key as U)) {
-        ret[key as keyof Omit<T, U>] = obj[key as keyof Omit<T, U>];
+      if (keysObj[key as U] !== true) {
+        ret[key as keyof Omit<T, K>] = obj[key as keyof Omit<T, K>];
       }
       return ret;
     },
-    {} as Omit<T, U>,
+    {} as Omit<T, K>,
   );
 }
 

tests/integration/umd/index.test.ts

@@ -19,6 +19,6 @@ test('throw error when using UMD with `bundle: false`', async () => {
   });
 
   expect(build).rejects.toThrowErrorMatchingInlineSnapshot(
-    `[Error: When "format" is set to "umd", "bundle" must not be set to "false", consider setting "bundle" to "true" or remove the field, it's default value is "true".]`,
+    `[Error: When using "umd" format, "bundle" must be set to "true". Since the default value for "bundle" is "true", so you can either explicitly set it to "true" or remove the field entirely.]`,
   );
 });