refactor(zod/v4): replace z.function with z.custom (#10602)

* test: add function validation tests

* refactor(zod/v4): replace `z.function` with `z.custom`

Author: colinaaa

packages/rspack-test-tools/tests/Validation.test.js

@@ -147,6 +147,29 @@ describe("Validation", () => {
 		`);
 			}
 		);
+
+		createTestCase(
+			"function type",
+			{
+				ignoreWarnings: [new Map()],
+				output: {
+					devtoolModuleFilenameTemplate: new Set()
+				}
+			},
+			message => {
+				throw new Error("should not have error");
+			},
+			"loose",
+			log => {
+				expect(log).toMatchInlineSnapshot(`
+			Array [
+			  Invalid configuration object. Rspack has been initialized using a configuration object that does not match the API schema.
+			- Expected string, received set at "output.devtoolModuleFilenameTemplate", or Expected function, received set at "output.devtoolModuleFilenameTemplate"
+			- Input not instance of RegExp at "ignoreWarnings[0]", or Expected function, received map at "ignoreWarnings[0]",
+			]
+		`);
+			}
+		);
 	});
 
 	describe("strict", () => {
@@ -189,6 +212,29 @@ describe("Validation", () => {
 				throw new Error("should not have log");
 			}
 		);
+
+		createTestCase(
+			"function type",
+			{
+				ignoreWarnings: [new Map()],
+				output: {
+					devtoolModuleFilenameTemplate: new Set(),
+					filename: []
+				}
+			},
+			message => {
+				expect(message).toMatchInlineSnapshot(`
+			Invalid configuration object. Rspack has been initialized using a configuration object that does not match the API schema.
+			- Expected string, received array at "output.filename", or Expected function, received array at "output.filename"
+			- Expected string, received set at "output.devtoolModuleFilenameTemplate", or Expected function, received set at "output.devtoolModuleFilenameTemplate"
+			- Input not instance of RegExp at "ignoreWarnings[0]", or Expected function, received map at "ignoreWarnings[0]"
+		`);
+			},
+			"strict",
+			log => {
+				throw new Error("should not have log");
+			}
+		);
 	});
 
 	describe("default (strict)", () => {
@@ -229,5 +275,27 @@ describe("Validation", () => {
 				throw new Error("should not have log");
 			}
 		);
+
+		createTestCase(
+			"function type",
+			{
+				ignoreWarnings: [new Map()],
+				output: {
+					devtoolModuleFilenameTemplate: new Set(),
+					filename: []
+				}
+			},
+			message => {
+				expect(message).toMatchInlineSnapshot(`
+			Invalid configuration object. Rspack has been initialized using a configuration object that does not match the API schema.
+			- Expected string, received array at "output.filename", or Expected function, received array at "output.filename"
+			- Expected string, received set at "output.devtoolModuleFilenameTemplate", or Expected function, received set at "output.devtoolModuleFilenameTemplate"
+			- Input not instance of RegExp at "ignoreWarnings[0]", or Expected function, received map at "ignoreWarnings[0]"
+		`);
+			},
+			log => {
+				throw new Error("should not have log");
+			}
+		);
 	});
 });

packages/rspack/src/builtin-plugin/IgnorePlugin.ts

@@ -4,6 +4,7 @@ import {
 } from "@rspack/binding";
 import { z } from "zod";
 
+import { anyFunction } from "../config/utils";
 import { validate } from "../util/validate";
 import { create } from "./base";
 
@@ -26,7 +27,7 @@ const IgnorePluginOptions = z.union([
 		resourceRegExp: z.instanceof(RegExp)
 	}),
 	z.object({
-		checkResource: z.function(z.tuple([z.string(), z.string()]), z.boolean())
+		checkResource: anyFunction
 	})
 ]) satisfies z.ZodType<IgnorePluginOptions>;
 

packages/rspack/src/builtin-plugin/html-plugin/options.ts

@@ -1,5 +1,6 @@
 import { z } from "zod";
 import { Compilation } from "../../Compilation";
+import { anyFunction } from "../../config/utils";
 import { validate } from "../../util/validate";
 
 const compilationOptionsMap: WeakMap<Compilation, HtmlRspackPluginOptions> =
@@ -9,23 +10,15 @@ export type TemplateRenderFunction = (
 	params: Record<string, any>
 ) => string | Promise<string>;
 
-const templateRenderFunction = z
-	.function()
-	.args(z.record(z.string(), z.any()))
-	.returns(
-		z.string().or(z.promise(z.string()))
-	) satisfies z.ZodType<TemplateRenderFunction>;
+const templateRenderFunction =
+	anyFunction satisfies z.ZodType<TemplateRenderFunction>;
 
 export type TemplateParamFunction = (
 	params: Record<string, any>
 ) => Record<string, any> | Promise<Record<string, any>>;
 
-const templateParamFunction = z
-	.function()
-	.args(z.record(z.string(), z.any()))
-	.returns(
-		z.record(z.string(), z.any()).or(z.promise(z.record(z.string(), z.any())))
-	) satisfies z.ZodType<TemplateParamFunction>;
+const templateParamFunction =
+	anyFunction satisfies z.ZodType<TemplateParamFunction>;
 
 export type HtmlRspackPluginOptions = {
 	/** The title to use for the generated HTML document. */
@@ -120,13 +113,8 @@ export type HtmlRspackPluginOptions = {
 	[key: string]: any;
 };
 
-const templateFilenameFunction = z
-	.function()
-	.args(z.string())
-	.returns(z.string());
-
 const pluginOptionsSchema = z.object({
-	filename: z.string().or(templateFilenameFunction).optional(),
+	filename: z.string().or(anyFunction).optional(),
 	template: z
 		.string()
 		.refine(

packages/rspack/src/config/utils.ts

@@ -18,6 +18,7 @@ import {
 	ZodUnion,
 	type ZodUnionOptions,
 	addIssueToContext,
+	getParsedType,
 	z
 } from "zod";
 import type { RspackOptions } from "./types";
@@ -222,3 +223,10 @@ export class ZodRspackCrossChecker<T> extends ZodType<T> {
 		return root.data;
 	}
 }
+
+export const anyFunction = z.custom<(...args: unknown[]) => any>(
+	data => typeof data === "function",
+	// Make the similar error message as zod v3
+	// https://github.com/colinhacks/zod/blob/64bfb7001cf6f2575bf38b5e6130bc73b4b0e371/packages/zod/src/v3/types.ts#L3821-L3828
+	input => ({ message: `Expected function, received ${getParsedType(input)}` })
+);