perf: regex from js and js resolver api (#10537)

Author: SyMind

crates/node_binding/src/raw_options/raw_module/mod.rs

@@ -101,10 +101,7 @@ impl TryFrom<RawRuleSetCondition> for rspack_core::RuleSetCondition {
   fn try_from(x: RawRuleSetCondition) -> rspack_error::Result<Self> {
     let result = match x {
       RawRuleSetCondition::string(s) => Self::String(s),
-      RawRuleSetCondition::regexp(r) => {
-        let reg = RspackRegex::with_flags(&r.source, &r.flags)?;
-        Self::Regexp(reg)
-      }
+      RawRuleSetCondition::regexp(r) => Self::Regexp(r),
       RawRuleSetCondition::logical(mut l) => {
         let l = l.get_mut(0).ok_or_else(|| {
           error!("TODO: use Box after https://github.com/napi-rs/napi-rs/issues/1500 landed")

crates/rspack_regex/src/napi.rs

@@ -1,9 +1,8 @@
 use napi::{
   bindgen_prelude::{
-    FromNapiValue, Function, JsObjectValue, Object, ToNapiValue, TypeName, Undefined,
-    ValidateNapiValue,
+    FromNapiValue, Function, JsObjectValue, ToNapiValue, TypeName, ValidateNapiValue,
   },
-  Env, JsValue, Unknown,
+  Env, JsValue, Unknown, ValueType,
 };
 
 use crate::RspackRegex;
@@ -25,32 +24,27 @@ impl FromNapiValue for RspackRegex {
     raw_env: napi::sys::napi_env,
     napi_val: napi::sys::napi_value,
   ) -> napi::Result<Self> {
-    let js_object = Object::from_raw(raw_env, napi_val);
+    let unknown = Unknown::from_raw_unchecked(raw_env, napi_val);
 
-    let env = Env::from(raw_env);
-    let global = env.get_global()?;
-    let object_prototype_to_string = global
-      .get_named_property_unchecked::<Object>("Object")?
-      .get_named_property_unchecked::<Object>("prototype")?
-      .get_named_property_unchecked::<Function>("toString")?;
-
-    let raw_undefined = Undefined::to_napi_value(raw_env, ())?;
-    let undefined = Unknown::from_napi_value(raw_env, raw_undefined)?;
-    let js_value = object_prototype_to_string.apply(js_object, undefined)?;
-    let js_string = js_value.coerce_to_string()?;
-    let js_utf8_string = js_string.into_utf8()?;
-    let object_type = js_utf8_string.as_str()?;
-
-    if object_type == "[object RegExp]" {
-      let source = js_object.get_named_property::<String>("source")?;
-      let flags = js_object.get_named_property::<String>("flags")?;
+    if unknown.get_type()? == ValueType::Object {
+      let object = unknown.coerce_to_object()?;
+      let source = object.get_named_property::<String>("source").map_err(|_| {
+        napi::Error::from_reason(
+          "Failed to extract the 'source' property. Ensure the value is a valid RegExp object.",
+        )
+      })?;
+      let flags = object.get_named_property::<String>("flags").map_err(|_| {
+        napi::Error::from_reason(
+          "Failed to extract the 'flags'. Ensure the value is a valid RegExp object.",
+        )
+      })?;
 
       Self::with_flags(&source, &flags)
         .map_err(|err| napi::Error::new(napi::Status::InvalidArg, err.to_string()))
     } else {
       Err(napi::Error::new(
         napi::Status::ObjectExpected,
-        format!("Expect value to be '[object RegExp]', but received {object_type}"),
+        "Expected a RegExp object as input value.",
       ))
     }
   }