Does statusCode "400" mean the subscription has expired?

[marcovtwout]

https://github.com/web-push-libs/web-push-php/blob/master/src/WebPush.php#L158

$error['expired'] = in_array($statusCode, array(400, 404, 410));

This code currently considers http 400 as "expired subscription". I don't think this is correct, in most cases it means something else is wrong with the request. Should 400 be removed from this list?

Background info:

• https://developers.google.com/web/fundamentals/engage-and-retain/push-notifications/common-issues-and-reporting-bugs#http_status_codes
• https://tools.ietf.org/html/draft-ietf-webpush-protocol-12

[Minishlink]

Thanks for your feedback. It was the case some time ago, but hopefully it's now more standardized. Let's remove the 400 case. :)

If you want to do a PR that's very welcome!

[marcovtwout]

Here it is: #103

[Minishlink]

Thanks :)