Fixed: outputReport option writes report for last file checked only (#160)

* Interpolate outputReport file placeholders.

Fixes #121

Original work by Tomasz Sterna (smokku).

* Use outputReport.filePath in the output conditional.

Without this a config that used
  eslint: {
    outputReport: {
      formatter: require("eslint/lib/formatters/stylish")
    }
  }

would create an file named "undefined" in the output path.

* Add tests for interpolated outputReport filenames.

* Include caught error in failure log.

* Add a working test for multiple files in entries.

Author: deryni

index.js

@@ -102,7 +102,7 @@ function lint(input, config, webpack) {
       })
       var messages = config.formatter(res.results)
 
-      if (config.outputReport) {
+      if (config.outputReport && config.outputReport.filePath) {
         var reportOutput
         // if a different formatter is passed in as an option use that
         if (config.outputReport.formatter) {
@@ -111,7 +111,14 @@ function lint(input, config, webpack) {
         else {
           reportOutput = messages
         }
-        webpack.emitFile(config.outputReport.filePath, reportOutput)
+        var filePath = loaderUtils.interpolateName(webpack,
+            config.outputReport.filePath, {
+              content: res.results.map(function(r) {
+                return r.source
+              }).join("\n"),
+            }
+        )
+        webpack.emitFile(filePath, reportOutput)
       }
 
       // default behavior: emit error only if we have errors

test/fixtures/error-multi-one.js

@@ -0,0 +1 @@
+var inone = stuff

test/fixtures/error-multi-two.js

@@ -0,0 +1 @@
+var intwo = stuff

test/fixtures/error-multi.js

@@ -0,0 +1 @@
+var foo = stuff

test/formatter-multiple-entries.js

@@ -0,0 +1,58 @@
+var test = require("ava")
+var webpack = require("webpack")
+var conf = require("./utils/conf")
+var fs = require("fs")
+
+test.cb("eslint-loader can be configured to write multiple eslint result files",
+function(t) {
+  var outputFilename = "outputReport-[name].txt"
+  var outputFilenamesArr = [
+    "outputReport-error-multi-two.txt",
+    "outputReport-error-multi-one.txt",
+    "outputReport-error-multi.txt",
+  ]
+  var config = conf(
+    {
+      entry: [
+        "./test/fixtures/error-multi-two.js",
+        "./test/fixtures/error-multi-one.js",
+        "./test/fixtures/error-multi.js",
+      ],
+    },
+    {
+      formatter: require("eslint/lib/formatters/checkstyle"),
+      outputReport: {
+        filePath: outputFilename,
+      },
+    }
+  )
+
+  /* Plan for the success count. Failure cases are going to fail anyway so the
+   * count being off for those cases doesn't matter. */
+  t.plan(outputFilenamesArr.length * 2)
+
+  webpack(config,
+  function(err, stats) {
+    if (err) {
+      throw err
+    }
+
+    for (var i = 0; i < outputFilenamesArr.length; i++) {
+      var filename = config.output.path + outputFilenamesArr[i]
+
+      try {
+        var contents = fs.readFileSync(filename, "utf8")
+
+        t.pass("File '" + filename + "' has been created")
+
+        t.is(stats.compilation.errors[i].message, contents,
+          "File '" + filename + "' Contents should equal output")
+      }
+      catch (e) {
+        t.fail("Expected file '" + filename + "' to have been created:" + e)
+      }
+    }
+
+    t.end()
+  })
+})