use res.end: reverting #27 #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -186,7 +186,7 @@ module.exports = function(compiler, options) { | |||
| res.setHeader(name, options.headers[name]); | |||
| } | |||
| } | |||
| res.send(content); | |||
| res.end(content); | |||
There was a problem hiding this comment.
What about a guard that defaults to the original implementation when Express isn't used (karma-webpack as an example)?
if (res.send) res.send(content);
else res.end(content);
There was a problem hiding this comment.
Yeah that could work as well if we want
There was a problem hiding this comment.
Updated with another commit (let me know if you need me to squash instead)
|
Thanks |
|
Thanks for merging and your work on webpack! |
This was referenced Jan 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert's #27
Assuming #58 is correct, I'm just adding a PR to revert.
Otherwise feel free to ignore/close.