Skip to content

Commit 199d2b0

Browse files
chore(deps): update ws
1 parent f94b84f commit 199d2b0

File tree

4 files changed

+14
-4
lines changed

4 files changed

+14
-4
lines changed

lib/Server.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1776,8 +1776,10 @@ class Server {
17761776

17771777
async stop() {
17781778
if (this.webSocketServer) {
1779-
process.nextTick(() => {
1780-
this.webSocketServer.implementation.close();
1779+
await new Promise((resolve) => {
1780+
this.webSocketServer.implementation.close(() => {
1781+
resolve();
1782+
});
17811783
});
17821784
}
17831785

lib/servers/WebsocketServer.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ module.exports = class WebsocketServer extends BaseServer {
7070
this.implementation.on("close", () => {
7171
clearInterval(interval);
7272

73+
for (const ws of this.clients) {
74+
ws.terminate();
75+
}
76+
7377
this.clients.clear();
7478
});
7579
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"strip-ansi": "^7.0.0",
5858
"url": "^0.11.0",
5959
"webpack-dev-middleware": "^5.0.0",
60-
"ws": "^7.5.3"
60+
"ws": "^8.1.0"
6161
},
6262
"devDependencies": {
6363
"@babel/cli": "^7.14.5",

test/server/Server.test.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,11 @@ describe("Server", () => {
176176
options: {
177177
webSocketServer: class CustomServerImplementation {
178178
constructor() {
179-
this.implementation = { close: () => {} };
179+
this.implementation = {
180+
close: (callback) => {
181+
callback();
182+
},
183+
};
180184
}
181185
},
182186
},

0 commit comments

Comments
 (0)