refactor: avoid new public options on class

Author: snitin315

lib/Server.js

@@ -636,20 +636,20 @@ class Server {
     let networkUrlIPv4;
     let networkUrlIPv6;
 
-    if (this.hostname) {
-      if (this.hostname === 'localhost') {
+    if (this.options.host) {
+      if (this.options.host === 'localhost') {
         localhost = prettyPrintUrl('localhost');
       } else {
         let isIP;
 
         try {
-          isIP = ipaddr.parse(this.hostname);
+          isIP = ipaddr.parse(this.options.host);
         } catch (error) {
           // Ignore
         }
 
         if (!isIP) {
-          server = prettyPrintUrl(this.hostname);
+          server = prettyPrintUrl(this.options.host);
         }
       }
     }
@@ -744,21 +744,22 @@ class Server {
     }
 
     if (this.options.open) {
-      const openTarget = prettyPrintUrl(this.hostname || 'localhost');
+      const openTarget = prettyPrintUrl(this.options.host || 'localhost');
 
       runOpen(openTarget, this.options.open, this.logger);
     }
   }
 
   listen(port, hostname, fn) {
     if (hostname === 'local-ip') {
-      this.hostname = internalIp.v4.sync() || internalIp.v6.sync() || '0.0.0.0';
+      this.options.host =
+        internalIp.v4.sync() || internalIp.v6.sync() || '0.0.0.0';
     } else if (hostname === 'local-ipv4') {
-      this.hostname = internalIp.v4.sync() || '0.0.0.0';
+      this.options.host = internalIp.v4.sync() || '0.0.0.0';
     } else if (hostname === 'local-ipv6') {
-      this.hostname = internalIp.v6.sync() || '::';
+      this.options.host = internalIp.v6.sync() || '::';
     } else {
-      this.hostname = hostname;
+      this.options.host = hostname;
     }
 
     if (typeof port !== 'undefined' && port !== this.options.port) {
@@ -773,7 +774,7 @@ class Server {
         .then((port) => {
           this.options.port = port;
 
-          return this.server.listen(port, this.hostname, (error) => {
+          return this.server.listen(port, this.options.host, (error) => {
             if (this.options.hot || this.options.liveReload) {
               this.createSocketServer();
             }
@@ -903,12 +904,12 @@ class Server {
     // these are removed from the hostname in url.parse(),
     // so we have the pure IPv6-address in hostname.
     // always allow localhost host, for convenience (hostname === 'localhost')
-    // allow hostname of listening address  (hostname === this.hostname)
+    // allow hostname of listening address  (hostname === this.options.host)
     const isValidHostname =
       ipaddr.IPv4.isValid(hostname) ||
       ipaddr.IPv6.isValid(hostname) ||
       hostname === 'localhost' ||
-      hostname === this.hostname;
+      hostname === this.options.host;
 
     if (isValidHostname) {
       return true;