Skip to content

Commit 6aec0cc

Browse files
fix: avoid webpack bug with eval
1 parent fcbca82 commit 6aec0cc

File tree

3 files changed

+27
-20
lines changed

3 files changed

+27
-20
lines changed

client-src/webpack.config.js

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,15 @@ const { merge } = require("webpack-merge");
77
const baseForModules = {
88
devtool: false,
99
mode: "production",
10-
experiments: {
11-
outputModule: true,
12-
},
10+
// TODO enable this in future after fix bug with `eval` in webpack
11+
// experiments: {
12+
// outputModule: true,
13+
// },
1314
output: {
1415
path: path.resolve(__dirname, "../client/modules"),
1516
library: {
16-
type: "module",
17+
// type: "module",
18+
type: "commonjs",
1719
},
1820
},
1921
optimization: {
@@ -40,21 +42,21 @@ module.exports = [
4042
output: {
4143
filename: "logger/index.js",
4244
},
43-
// module: {
44-
// rules: [
45-
// {
46-
// test: /\.js$/,
47-
// use: [
48-
// {
49-
// loader: "babel-loader",
50-
// options: {
51-
// plugins: ["@babel/plugin-transform-object-assign"],
52-
// },
53-
// },
54-
// ],
55-
// },
56-
// ],
57-
// },
45+
module: {
46+
rules: [
47+
{
48+
test: /\.js$/,
49+
use: [
50+
{
51+
loader: "babel-loader",
52+
options: {
53+
plugins: ["@babel/plugin-transform-object-assign"],
54+
},
55+
},
56+
],
57+
},
58+
],
59+
},
5860
plugins: [
5961
new webpack.DefinePlugin({
6062
Symbol:
@@ -76,6 +78,9 @@ module.exports = [
7678
entry: path.join(__dirname, "modules/sockjs-client/index.js"),
7779
output: {
7880
filename: "sockjs-client/index.js",
81+
library: "SockJS",
82+
libraryTarget: "umd",
83+
globalObject: "(typeof self !== 'undefined' ? self : this)",
7984
},
8085
}),
8186
];

test/e2e/entry.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ describe("entry", () => {
4040

4141
const itOnlyWebpack5 = isWebpack5 ? it : it.skip;
4242

43-
it("should work with single entry", async () => {
43+
it.only("should work with single entry", async () => {
4444
const compiler = webpack({ ...config, entry: entryFirst });
4545
const devServerOptions = {
4646
host: "127.0.0.1",
@@ -73,6 +73,7 @@ describe("entry", () => {
7373
pageErrors.push(error);
7474
});
7575

76+
console.log(`http://127.0.0.1:${port}/main`);
7677
await page.goto(`http://127.0.0.1:${port}/main`, {
7778
waitUntil: "networkidle0",
7879
});

test/fixtures/client-config/webpack.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ const HTMLContent = `
1212
`;
1313

1414
module.exports = {
15+
devtool: "eval-nosources-cheap-source-map",
1516
mode: "development",
1617
context: __dirname,
1718
stats: "none",

0 commit comments

Comments
 (0)