Skip to content

Commit 6eead33

Browse files
refactor: test
1 parent ca22b00 commit 6eead33

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

test/e2e/web-socket-server-url.test.js

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1532,12 +1532,13 @@ describe('web socket server URL', () => {
15321532
});
15331533
});
15341534

1535-
it(`should work when "port" option is "auto" ("${webSocketServer}")`, async () => {
1535+
it(`should work when "host" option is IPv4 ("${webSocketServer}")`, async () => {
1536+
const hostname = internalIp.v4.sync();
15361537
const compiler = webpack(config);
15371538
const devServerOptions = {
15381539
webSocketServer,
1539-
port: 'auto',
1540-
host: '0.0.0.0',
1540+
port: port1,
1541+
host: hostname,
15411542
};
15421543
const server = new Server(devServerOptions, compiler);
15431544

@@ -1553,8 +1554,6 @@ describe('web socket server URL', () => {
15531554
});
15541555
});
15551556

1556-
const resolvedFreePort = server.options.port;
1557-
15581557
const { page, browser } = await runBrowser();
15591558

15601559
const pageErrors = [];
@@ -1573,8 +1572,8 @@ describe('web socket server URL', () => {
15731572
if (webSocketServer === 'ws') {
15741573
const client = page._client;
15751574

1576-
client.on('Network.webSocketCreated', (request) => {
1577-
webSocketRequests.push(request);
1575+
client.on('Network.webSocketCreated', (test) => {
1576+
webSocketRequests.push(test);
15781577
});
15791578
} else {
15801579
page.on('request', (request) => {
@@ -1584,14 +1583,14 @@ describe('web socket server URL', () => {
15841583
});
15851584
}
15861585

1587-
await page.goto(`http://127.0.0.1:${resolvedFreePort}/main`, {
1586+
await page.goto(`http://${hostname}:${port1}/main`, {
15881587
waitUntil: 'networkidle0',
15891588
});
15901589

15911590
const webSocketRequest = webSocketRequests[0];
15921591

15931592
expect(webSocketRequest.url).toContain(
1594-
`${websocketURLProtocol}://127.0.0.1:${resolvedFreePort}/ws`
1593+
`${websocketURLProtocol}://${hostname}:${port1}/ws`
15951594
);
15961595
expect(consoleMessages.map((message) => message.text())).toMatchSnapshot(
15971596
'console messages'
@@ -1612,13 +1611,13 @@ describe('web socket server URL', () => {
16121611
});
16131612
});
16141613

1615-
it(`should work when "host" option is IPv4 ("${webSocketServer}")`, async () => {
1614+
it(`should work when "host" option is "local-ip" ("${webSocketServer}")`, async () => {
16161615
const hostname = internalIp.v4.sync();
16171616
const compiler = webpack(config);
16181617
const devServerOptions = {
16191618
webSocketServer,
16201619
port: port1,
1621-
host: hostname,
1620+
host: 'local-ip',
16221621
};
16231622
const server = new Server(devServerOptions, compiler);
16241623

@@ -1691,13 +1690,13 @@ describe('web socket server URL', () => {
16911690
});
16921691
});
16931692

1694-
it(`should work when "host" option is "local-ip" ("${webSocketServer}")`, async () => {
1693+
it(`should work when "host" option is "local-ipv4" ("${webSocketServer}")`, async () => {
16951694
const hostname = internalIp.v4.sync();
16961695
const compiler = webpack(config);
16971696
const devServerOptions = {
16981697
webSocketServer,
16991698
port: port1,
1700-
host: 'local-ip',
1699+
host: 'local-ipv4',
17011700
};
17021701
const server = new Server(devServerOptions, compiler);
17031702

@@ -1770,13 +1769,12 @@ describe('web socket server URL', () => {
17701769
});
17711770
});
17721771

1773-
it(`should work when "host" option is "local-ipv4" ("${webSocketServer}")`, async () => {
1774-
const hostname = internalIp.v4.sync();
1772+
it(`should work when "port" option is "auto" ("${webSocketServer}")`, async () => {
17751773
const compiler = webpack(config);
17761774
const devServerOptions = {
17771775
webSocketServer,
1778-
port: port1,
1779-
host: 'local-ipv4',
1776+
port: 'auto',
1777+
host: '0.0.0.0',
17801778
};
17811779
const server = new Server(devServerOptions, compiler);
17821780

@@ -1792,6 +1790,8 @@ describe('web socket server URL', () => {
17921790
});
17931791
});
17941792

1793+
const resolvedFreePort = server.options.port;
1794+
17951795
const { page, browser } = await runBrowser();
17961796

17971797
const pageErrors = [];
@@ -1810,8 +1810,8 @@ describe('web socket server URL', () => {
18101810
if (webSocketServer === 'ws') {
18111811
const client = page._client;
18121812

1813-
client.on('Network.webSocketCreated', (test) => {
1814-
webSocketRequests.push(test);
1813+
client.on('Network.webSocketCreated', (request) => {
1814+
webSocketRequests.push(request);
18151815
});
18161816
} else {
18171817
page.on('request', (request) => {
@@ -1821,14 +1821,14 @@ describe('web socket server URL', () => {
18211821
});
18221822
}
18231823

1824-
await page.goto(`http://${hostname}:${port1}/main`, {
1824+
await page.goto(`http://127.0.0.1:${resolvedFreePort}/main`, {
18251825
waitUntil: 'networkidle0',
18261826
});
18271827

18281828
const webSocketRequest = webSocketRequests[0];
18291829

18301830
expect(webSocketRequest.url).toContain(
1831-
`${websocketURLProtocol}://${hostname}:${port1}/ws`
1831+
`${websocketURLProtocol}://127.0.0.1:${resolvedFreePort}/ws`
18321832
);
18331833
expect(consoleMessages.map((message) => message.text())).toMatchSnapshot(
18341834
'console messages'

0 commit comments

Comments
 (0)