test: update

Author: alexander-akait

bin/process-arguments.js

@@ -8,15 +8,20 @@ const path = require('path');
 const cliAddedItems = new WeakMap();
 
 const getObjectAndProperty = (config, schemaPath, index = 0) => {
-  if (!schemaPath) return { value: config };
+  if (!schemaPath) {
+    return { value: config };
+  }
+
   const parts = schemaPath.split('.');
   const property = parts.pop();
   let current = config;
   let i = 0;
+
   for (const part of parts) {
     const isArray = part.endsWith('[]');
     const name = isArray ? part.slice(0, -2) : part;
     let value = current[name];
+
     if (isArray) {
       // eslint-disable-next-line no-undefined
       if (value === undefined) {
@@ -32,14 +37,18 @@ const getObjectAndProperty = (config, schemaPath, index = 0) => {
         };
       } else {
         let addedItems = cliAddedItems.get(value) || 0;
+
         while (addedItems <= index) {
           // eslint-disable-next-line no-undefined
           value.push(undefined);
           // eslint-disable-next-line no-plusplus
           addedItems++;
         }
+
         cliAddedItems.set(value, addedItems);
+
         const x = value.length - addedItems + index;
+
         // eslint-disable-next-line no-undefined
         if (value[x] === undefined) {
           value[x] = {};
@@ -51,6 +60,7 @@ const getObjectAndProperty = (config, schemaPath, index = 0) => {
             },
           };
         }
+
         value = value[x];
       }
       // eslint-disable-next-line no-undefined
@@ -65,37 +75,49 @@ const getObjectAndProperty = (config, schemaPath, index = 0) => {
         },
       };
     }
+
     current = value;
     // eslint-disable-next-line no-plusplus
     i++;
   }
+
   const value = current[property];
+
   if (property.endsWith('[]')) {
     const name = property.slice(0, -2);
+    // eslint-disable-next-line no-shadow
     const value = current[name];
+
     // eslint-disable-next-line no-undefined
     if (value === undefined) {
       // eslint-disable-next-line no-undefined
       current[name] = [...Array.from({ length: index }), undefined];
       cliAddedItems.set(current[name], index + 1);
+
       // eslint-disable-next-line no-undefined
       return { object: current[name], property: index, value: undefined };
     } else if (!Array.isArray(value)) {
       // eslint-disable-next-line no-undefined
       current[name] = [value, ...Array.from({ length: index }), undefined];
       cliAddedItems.set(current[name], index + 1);
+
       // eslint-disable-next-line no-undefined
       return { object: current[name], property: index + 1, value: undefined };
     }
+
     let addedItems = cliAddedItems.get(value) || 0;
+
     while (addedItems <= index) {
       // eslint-disable-next-line no-undefined
       value.push(undefined);
       // eslint-disable-next-line no-plusplus
       addedItems++;
     }
+
     cliAddedItems.set(value, addedItems);
+
     const x = value.length - addedItems + index;
+
     // eslint-disable-next-line no-undefined
     if (value[x] === undefined) {
       value[x] = {};
@@ -107,12 +129,14 @@ const getObjectAndProperty = (config, schemaPath, index = 0) => {
         },
       };
     }
+
     return {
       object: value,
       property: x,
       value: value[x],
     };
   }
+
   return { object: current, property, value };
 };
 
@@ -130,35 +154,60 @@ const parseValueForArgumentConfig = (argConfig, value) => {
       }
       break;
     case 'number':
-      if (typeof value === 'number') return value;
+      if (typeof value === 'number') {
+        return value;
+      }
+
       if (typeof value === 'string' && /^[+-]?\d*(\.\d*)[eE]\d+$/) {
         const n = +value;
         if (!isNaN(n)) return n;
       }
+
       break;
     case 'boolean':
-      if (typeof value === 'boolean') return value;
-      if (value === 'true') return true;
-      if (value === 'false') return false;
+      if (typeof value === 'boolean') {
+        return value;
+      }
+
+      if (value === 'true') {
+        return true;
+      }
+
+      if (value === 'false') {
+        return false;
+      }
+
       break;
     case 'RegExp':
-      if (value instanceof RegExp) return value;
+      if (value instanceof RegExp) {
+        return value;
+      }
+
       if (typeof value === 'string') {
         // cspell:word yugi
         const match = /^\/(.*)\/([yugi]*)$/.exec(value);
+
         if (match && !/[^\\]\//.test(match[1])) {
           return new RegExp(match[1], match[2]);
         }
       }
+
       break;
     case 'enum':
-      if (argConfig.values.includes(value)) return value;
+      if (argConfig.values.includes(value)) {
+        return value;
+      }
+
       for (const item of argConfig.values) {
         if (`${item}` === value) return item;
       }
+
       break;
     case 'reset':
-      if (value === true) return [];
+      if (value === true) {
+        return [];
+      }
+
       break;
   }
 };
@@ -184,8 +233,13 @@ const setValue = (config, schemaPath, value, index) => {
     schemaPath,
     index
   );
-  if (problem) return problem;
+
+  if (problem) {
+    return problem;
+  }
+
   object[property] = value;
+
   return null;
 };
 
@@ -197,7 +251,9 @@ const processArgumentConfig = (argConfig, config, value, index) => {
       path: argConfig.path,
     };
   }
+
   const parsed = parseValueForArgumentConfig(argConfig, value);
+
   // eslint-disable-next-line no-undefined
   if (parsed === undefined) {
     return {
@@ -206,41 +262,56 @@ const processArgumentConfig = (argConfig, config, value, index) => {
       expected: getExpectedValue(argConfig),
     };
   }
+
   const problem = setValue(config, argConfig.path, parsed, index);
-  if (problem) return problem;
+
+  if (problem) {
+    return problem;
+  }
+
   return null;
 };
 
 const processArguments = (args, config, values) => {
   const problems = [];
+
   for (const key of Object.keys(values)) {
     const arg = args[key];
+
     if (!arg) {
       problems.push({
         type: 'unknown-argument',
         path: '',
         argument: key,
       });
+
       // eslint-disable-next-line no-continue
       continue;
     }
+
     const processValue = (value, i) => {
       const currentProblems = [];
+
       for (const argConfig of arg.configs) {
         const problem = processArgumentConfig(argConfig, config, value, i);
+
         if (!problem) {
           return;
         }
+
         currentProblems.push({
           ...problem,
           argument: key,
           value,
           index: i,
         });
       }
+
       problems.push(...currentProblems);
     };
+
     const value = values[key];
+
     if (Array.isArray(value)) {
       for (let i = 0; i < value.length; i++) {
         processValue(value[i], i);
@@ -250,7 +321,11 @@ const processArguments = (args, config, values) => {
       processValue(value, undefined);
     }
   }
-  if (problems.length === 0) return null;
+
+  if (problems.length === 0) {
+    return null;
+  }
+
   return problems;
 };
 

jest.config.js

@@ -8,6 +8,7 @@ module.exports = {
     '<rootDir>/test/',
     '<rootDir>/client/',
   ],
+  testPathIgnorePatterns: ['<rootDir>/bin/this/process-arguments.js'],
   moduleFileExtensions: ['js', 'json'],
   testMatch: ['**/test/**/*.test.js'],
   snapshotResolver: '<rootDir>/test/helpers/snapshotResolver.js',