Skip to content

Commit 7c74c05

Browse files
authored
refactor: use Symbol and boolean
1 parent fba2ba1 commit 7c74c05

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

lib/Server.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,11 @@ class Server {
4242
constructor(compiler, options = {}) {
4343
validate(schema, options, 'webpack Dev Server');
4444

45-
if (compiler.devServer) {
45+
const devServerSymbol = Symbol.for('webpack-dev-server');
46+
if (compiler[devServerSymbol]) {
4647
throw new Error('The compiler already has a dev server attached.');
4748
}
48-
compiler.devServer = this;
49+
compiler[devServerSymbol] = true;
4950

5051
this.compiler = compiler;
5152
this.options = options;

test/server/Server.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,11 @@ describe('Server', () => {
8686
});
8787

8888
describe('devServer property of the compiler', () => {
89-
it('should reference the Server instance', (done) => {
89+
it('should be true', (done) => {
9090
const compiler = webpack(config);
9191
const server = new Server(compiler, baseDevConfig);
9292

93-
expect(compiler.devServer).toBe(server);
93+
expect(compiler[Symbol.for('webpack-dev-server')]).toBe(true);
9494

9595
compiler.hooks.done.tap('webpack-dev-server', () => {
9696
server.close(done);

0 commit comments

Comments
 (0)