Skip to content

Commit 857861b

Browse files
authored
docs: remove public (#3350)
1 parent 2d68701 commit 857861b

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ Options:
124124
--no-history-api-fallback Do not fallback to /index.html for Single Page Applications.
125125
--compress Enable gzip compression.
126126
--no-compress Disable gzip compression.
127-
--public <value> The public hostname/ip address of the server.
128127
--firewall [value...] Enable firewall or set hosts that are allowed to access the dev server.
129128
--no-firewall Disable firewall.
130129
--watch-files <value...> Watch static files for file changes.

examples/cli/web-socket-url/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
# CLI: Public Option Protocol
1+
# CLI: Web Socket URL Option Protocol
22

33
```console
44
npx webpack serve
55
```
66

77
_NOTE: replace `<insert local ip>` with your local IP Address._
88

9-
You're now able to explicitly define the protocol used with the `public` option
9+
You're now able to explicitly define the protocol used with the `client.webSocketURL` option
1010
(have a look to the config provided in `webpack.config.js`).
1111

1212
## What Should Happen

test/e2e/web-socket-server-and-url.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ for (const webSocketServerType of webSocketServerTypes) {
404404
afterAll(testServer.close);
405405

406406
describe('browser client', () => {
407-
it('uses the correct public hostname and path', (done) => {
407+
it('uses the correct webSocketURL hostname and path', (done) => {
408408
runBrowser().then(({ page, browser }) => {
409409
waitForTest(browser, page, /foo\/test\/bar/, (websocketUrl) => {
410410
expect(websocketUrl).toContain(

0 commit comments

Comments
 (0)